[PR #150] [MERGED] Fixed a bug with secure-string conversion #156

New issue

Closed

opened 2026-03-02 02:10:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 02:10:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/community-scripts/pull/150
Author: @JxD-DeciSion
Created: 5/16/2023
Status: ✅ Merged
Merged: 5/18/2023
Merged by: @silversword411

Base: main ← Head: ad-join-script-fix-1

📝 Commits (1)

6829d41 Fixed a bug with secure-string convertion

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 scripts/Win_AD_Join_Computer.ps1 (+4 -3)

📄 Description

Background: Had issues joining our AD and reached out to free-support

While investigating the problem I came across this StackOverflow post

Did some testing and encountered a "credentials not correct" error. But this time the script actually created the log file and I could verify the script was doing something. After some more investigation I found out that my password contained a "$" which had to be escaped. I dont know if its wanted or necessary but I added a little hint that "$" characters have to be escaped.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/community-scripts/pull/150 **Author:** [@JxD-DeciSion](https://github.com/JxD-DeciSion) **Created:** 5/16/2023 **Status:** ✅ Merged **Merged:** 5/18/2023 **Merged by:** [@silversword411](https://github.com/silversword411) **Base:** `main` ← **Head:** `ad-join-script-fix-1` --- ### 📝 Commits (1) - [`6829d41`](https://github.com/amidaware/community-scripts/commit/6829d419bc7a440f0cefaa3814f214f04e7be00d) Fixed a bug with secure-string convertion ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `scripts/Win_AD_Join_Computer.ps1` (+4 -3) </details> ### 📄 Description Background: [Had issues joining our AD and reached out to free-support ](https://discord.com/channels/736478043522072608/1107671030115340378) While investigating the problem I came across [this StackOverflow post](https://stackoverflow.com/a/23004997) Did some testing and encountered a "credentials not correct" error. But this time the script actually created the log file and I could verify the script was doing something. After some more investigation I found out that my password contained a "$" which had to be escaped. I dont know if its wanted or necessary but I added a little hint that "$" characters have to be escaped. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>