[PR #14] [MERGED] Improve Readability #16

New issue

Closed

opened 2026-02-26 01:35:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 01:35:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jtsalva/cloudmare/pull/14
Author: @jtsalva
Created: 5/3/2020
Status: ✅ Merged
Merged: 5/3/2020
Merged by: @jtsalva

Base: master ← Head: readability

📝 Commits (3)

9e2d028 Move logic to filter invalid keys when creating DNSRecord into local function
1cc4d59 Use built-in method String.isNullOrBlank
8919364 Comply with ktlint

📊 Changes

62 files changed (+167 additions, -182 deletions)

View changed files

📝 app/src/main/java/dev/jtsalva/cloudmare/ActivityUtil.kt (+6 -5)
📝 app/src/main/java/dev/jtsalva/cloudmare/AnalyticsActivity.kt (+13 -10)
📝 app/src/main/java/dev/jtsalva/cloudmare/Auth.kt (+2 -2)
📝 app/src/main/java/dev/jtsalva/cloudmare/CloudMareActivity.kt (+4 -3)
📝 app/src/main/java/dev/jtsalva/cloudmare/DNSRecordActivity.kt (+5 -6)
📝 app/src/main/java/dev/jtsalva/cloudmare/DNSRecordListActivity.kt (+1 -4)
📝 app/src/main/java/dev/jtsalva/cloudmare/Dialog.kt (+24 -17)
📝 app/src/main/java/dev/jtsalva/cloudmare/MenuButtonInitializer.kt (+1 -1)
📝 app/src/main/java/dev/jtsalva/cloudmare/PaginationListener.kt (+10 -8)
📝 app/src/main/java/dev/jtsalva/cloudmare/SSLActivity.kt (+0 -1)
📝 app/src/main/java/dev/jtsalva/cloudmare/Settings.kt (+2 -2)
📝 app/src/main/java/dev/jtsalva/cloudmare/SwipeRefreshable.kt (+1 -1)
📝 app/src/main/java/dev/jtsalva/cloudmare/UserActivity.kt (+0 -1)
📝 app/src/main/java/dev/jtsalva/cloudmare/ZoneListActivity.kt (+1 -1)
📝 app/src/main/java/dev/jtsalva/cloudmare/adapter/DNSRecordListAdapter.kt (+2 -4)
📝 app/src/main/java/dev/jtsalva/cloudmare/adapter/TextUtil.kt (+1 -1)
📝 app/src/main/java/dev/jtsalva/cloudmare/adapter/ZoneListAdapter.kt (+1 -3)
📝 app/src/main/java/dev/jtsalva/cloudmare/api/APIUtil.kt (+5 -4)
📝 app/src/main/java/dev/jtsalva/cloudmare/api/AuthenticatedJsonArrayRequest.kt (+4 -5)
📝 app/src/main/java/dev/jtsalva/cloudmare/api/AuthenticatedJsonObjectRequest.kt (+2 -3)

...and 42 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jtsalva/cloudmare/pull/14 **Author:** [@jtsalva](https://github.com/jtsalva) **Created:** 5/3/2020 **Status:** ✅ Merged **Merged:** 5/3/2020 **Merged by:** [@jtsalva](https://github.com/jtsalva) **Base:** `master` ← **Head:** `readability` --- ### 📝 Commits (3) - [`9e2d028`](https://github.com/jtsalva/cloudmare/commit/9e2d02833747efac9ef5ee7a12ff0e5443683c73) Move logic to filter invalid keys when creating DNSRecord into local function - [`1cc4d59`](https://github.com/jtsalva/cloudmare/commit/1cc4d59d9eee5466337943b907da2de18346cda6) Use built-in method String.isNullOrBlank - [`8919364`](https://github.com/jtsalva/cloudmare/commit/89193646a6c5bbd93f0e7f194aed7045c3fb0595) Comply with ktlint ### 📊 Changes **62 files changed** (+167 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/dev/jtsalva/cloudmare/ActivityUtil.kt` (+6 -5) 📝 `app/src/main/java/dev/jtsalva/cloudmare/AnalyticsActivity.kt` (+13 -10) 📝 `app/src/main/java/dev/jtsalva/cloudmare/Auth.kt` (+2 -2) 📝 `app/src/main/java/dev/jtsalva/cloudmare/CloudMareActivity.kt` (+4 -3) 📝 `app/src/main/java/dev/jtsalva/cloudmare/DNSRecordActivity.kt` (+5 -6) 📝 `app/src/main/java/dev/jtsalva/cloudmare/DNSRecordListActivity.kt` (+1 -4) 📝 `app/src/main/java/dev/jtsalva/cloudmare/Dialog.kt` (+24 -17) 📝 `app/src/main/java/dev/jtsalva/cloudmare/MenuButtonInitializer.kt` (+1 -1) 📝 `app/src/main/java/dev/jtsalva/cloudmare/PaginationListener.kt` (+10 -8) 📝 `app/src/main/java/dev/jtsalva/cloudmare/SSLActivity.kt` (+0 -1) 📝 `app/src/main/java/dev/jtsalva/cloudmare/Settings.kt` (+2 -2) 📝 `app/src/main/java/dev/jtsalva/cloudmare/SwipeRefreshable.kt` (+1 -1) 📝 `app/src/main/java/dev/jtsalva/cloudmare/UserActivity.kt` (+0 -1) 📝 `app/src/main/java/dev/jtsalva/cloudmare/ZoneListActivity.kt` (+1 -1) 📝 `app/src/main/java/dev/jtsalva/cloudmare/adapter/DNSRecordListAdapter.kt` (+2 -4) 📝 `app/src/main/java/dev/jtsalva/cloudmare/adapter/TextUtil.kt` (+1 -1) 📝 `app/src/main/java/dev/jtsalva/cloudmare/adapter/ZoneListAdapter.kt` (+1 -3) 📝 `app/src/main/java/dev/jtsalva/cloudmare/api/APIUtil.kt` (+5 -4) 📝 `app/src/main/java/dev/jtsalva/cloudmare/api/AuthenticatedJsonArrayRequest.kt` (+4 -5) 📝 `app/src/main/java/dev/jtsalva/cloudmare/api/AuthenticatedJsonObjectRequest.kt` (+2 -3) _...and 42 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>