[PR #8] [MERGED] Feature/darkmode #12

New issue

Closed

opened 2026-02-26 01:35:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 01:35:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jtsalva/cloudmare/pull/8
Author: @jtsalva
Created: 11/5/2019
Status: ✅ Merged
Merged: 11/5/2019
Merged by: @jtsalva

Base: master ← Head: feature/darkmode

📝 Commits (10+)

f649647 make compatible for darkmode
a335881 add settings icon resource
1ac3c78 add ability to set app theme
3ee9d62 set theme onStart
fb20e1a switch to using Theme.AppCompat.DayNight
ff58546 use simpler bottom border
5d62af0 add black and white
7fd3521 make graph label color adjust to theme
6673bce fix issue causing Authorization header to be set instead of X-Auth
fbfc008 move assignment of Auth.email inside condition

📊 Changes

25 files changed (+324 additions, -80 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+3 -0)
📝 app/src/main/java/dev/jtsalva/cloudmare/AnalyticsActivity.kt (+43 -31)
📝 app/src/main/java/dev/jtsalva/cloudmare/Auth.kt (+1 -1)
📝 app/src/main/java/dev/jtsalva/cloudmare/CloudMareActivity.kt (+5 -0)
📝 app/src/main/java/dev/jtsalva/cloudmare/DomainListActivity.kt (+10 -1)
➕ app/src/main/java/dev/jtsalva/cloudmare/Settings.kt (+25 -0)
➕ app/src/main/java/dev/jtsalva/cloudmare/SettingsActivity.kt (+71 -0)
📝 app/src/main/java/dev/jtsalva/cloudmare/UserActivity.kt (+1 -1)
➕ app/src/main/java/dev/jtsalva/cloudmare/viewmodel/SettingsViewModel.kt (+37 -0)
➕ app/src/main/res/drawable-hdpi/baseline_settings_applications_white_48.png (+0 -0)
➕ app/src/main/res/drawable-mdpi/baseline_settings_applications_white_48.png (+0 -0)
➕ app/src/main/res/drawable-xhdpi/baseline_settings_applications_white_48.png (+0 -0)
➕ app/src/main/res/drawable-xxhdpi/baseline_settings_applications_white_48.png (+0 -0)
➕ app/src/main/res/drawable-xxxhdpi/baseline_settings_applications_white_48.png (+0 -0)
📝 app/src/main/res/drawable/bottom_border_background.xml (+4 -13)
📝 app/src/main/res/layout/activity_caching.xml (+0 -2)
➕ app/src/main/res/layout/activity_settings.xml (+54 -0)
📝 app/src/main/res/layout/activity_ssl.xml (+0 -1)
📝 app/src/main/res/layout/activity_user.xml (+5 -1)
📝 app/src/main/res/layout/button_option_view.xml (+0 -1)

...and 5 more files

📄 Description

Add darkmode, includes minor Auth fixes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jtsalva/cloudmare/pull/8 **Author:** [@jtsalva](https://github.com/jtsalva) **Created:** 11/5/2019 **Status:** ✅ Merged **Merged:** 11/5/2019 **Merged by:** [@jtsalva](https://github.com/jtsalva) **Base:** `master` ← **Head:** `feature/darkmode` --- ### 📝 Commits (10+) - [`f649647`](https://github.com/jtsalva/cloudmare/commit/f6496472d228210a7b6887204840a8e841a5fe6a) make compatible for darkmode - [`a335881`](https://github.com/jtsalva/cloudmare/commit/a335881eeee18a87cce44ae3357fd15981b8bfd6) add settings icon resource - [`1ac3c78`](https://github.com/jtsalva/cloudmare/commit/1ac3c78914e2255635c658ee25f35f1ef8817eea) add ability to set app theme - [`3ee9d62`](https://github.com/jtsalva/cloudmare/commit/3ee9d628cc359ac8397dad5ed849ac5c870f0dd1) set theme onStart - [`fb20e1a`](https://github.com/jtsalva/cloudmare/commit/fb20e1a0371cf1fcb712c14b083b9ebf08bbb6bd) switch to using Theme.AppCompat.DayNight - [`ff58546`](https://github.com/jtsalva/cloudmare/commit/ff585461929acb8febb669bf8e6f03dacaf08a8d) use simpler bottom border - [`5d62af0`](https://github.com/jtsalva/cloudmare/commit/5d62af001687126442ddd1f2718ba0957ddab3e7) add black and white - [`7fd3521`](https://github.com/jtsalva/cloudmare/commit/7fd35216000c1c6bd0c5d543eef69c71ed8783ae) make graph label color adjust to theme - [`6673bce`](https://github.com/jtsalva/cloudmare/commit/6673bce1487329d601889bac39cf3b7dfd3e08ff) fix issue causing Authorization header to be set instead of X-Auth - [`fbfc008`](https://github.com/jtsalva/cloudmare/commit/fbfc008d796b9b1a36a72829bf1c3e6aa4a6b288) move assignment of Auth.email inside condition ### 📊 Changes **25 files changed** (+324 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+3 -0) 📝 `app/src/main/java/dev/jtsalva/cloudmare/AnalyticsActivity.kt` (+43 -31) 📝 `app/src/main/java/dev/jtsalva/cloudmare/Auth.kt` (+1 -1) 📝 `app/src/main/java/dev/jtsalva/cloudmare/CloudMareActivity.kt` (+5 -0) 📝 `app/src/main/java/dev/jtsalva/cloudmare/DomainListActivity.kt` (+10 -1) ➕ `app/src/main/java/dev/jtsalva/cloudmare/Settings.kt` (+25 -0) ➕ `app/src/main/java/dev/jtsalva/cloudmare/SettingsActivity.kt` (+71 -0) 📝 `app/src/main/java/dev/jtsalva/cloudmare/UserActivity.kt` (+1 -1) ➕ `app/src/main/java/dev/jtsalva/cloudmare/viewmodel/SettingsViewModel.kt` (+37 -0) ➕ `app/src/main/res/drawable-hdpi/baseline_settings_applications_white_48.png` (+0 -0) ➕ `app/src/main/res/drawable-mdpi/baseline_settings_applications_white_48.png` (+0 -0) ➕ `app/src/main/res/drawable-xhdpi/baseline_settings_applications_white_48.png` (+0 -0) ➕ `app/src/main/res/drawable-xxhdpi/baseline_settings_applications_white_48.png` (+0 -0) ➕ `app/src/main/res/drawable-xxxhdpi/baseline_settings_applications_white_48.png` (+0 -0) 📝 `app/src/main/res/drawable/bottom_border_background.xml` (+4 -13) 📝 `app/src/main/res/layout/activity_caching.xml` (+0 -2) ➕ `app/src/main/res/layout/activity_settings.xml` (+54 -0) 📝 `app/src/main/res/layout/activity_ssl.xml` (+0 -1) 📝 `app/src/main/res/layout/activity_user.xml` (+5 -1) 📝 `app/src/main/res/layout/button_option_view.xml` (+0 -1) _...and 5 more files_ </details> ### 📄 Description Add darkmode, includes minor Auth fixes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>