[PR #10] [MERGED] Refactor/api/translator #11

Closed
opened 2026-02-26 01:35:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jtsalva/cloudmare/pull/10
Author: @jtsalva
Created: 11/20/2019
Status: Merged
Merged: 11/20/2019
Merged by: @jtsalva

Base: masterHead: refactor/api/translator


📝 Commits (2)

  • 59f8799 refactor translators to use one class
  • b66430c refactor to use new translators

📊 Changes

9 files changed (+91 additions, -116 deletions)

View changed files

📝 app/src/main/java/dev/jtsalva/cloudmare/SettingsActivity.kt (+4 -13)
app/src/main/java/dev/jtsalva/cloudmare/api/IdTranslator.kt (+9 -0)
📝 app/src/main/java/dev/jtsalva/cloudmare/api/dns/DNSRecord.kt (+39 -45)
📝 app/src/main/java/dev/jtsalva/cloudmare/api/zonesettings/ZoneSetting.kt (+29 -49)
📝 app/src/main/java/dev/jtsalva/cloudmare/viewmodel/CachingViewModel.kt (+3 -3)
📝 app/src/main/java/dev/jtsalva/cloudmare/viewmodel/DNSRecordViewModel.kt (+2 -2)
📝 app/src/main/java/dev/jtsalva/cloudmare/viewmodel/NetworkViewModel.kt (+3 -2)
📝 app/src/main/java/dev/jtsalva/cloudmare/viewmodel/SSLViewModel.kt (+1 -1)
📝 app/src/main/java/dev/jtsalva/cloudmare/viewmodel/SettingsViewModel.kt (+1 -1)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jtsalva/cloudmare/pull/10 **Author:** [@jtsalva](https://github.com/jtsalva) **Created:** 11/20/2019 **Status:** ✅ Merged **Merged:** 11/20/2019 **Merged by:** [@jtsalva](https://github.com/jtsalva) **Base:** `master` ← **Head:** `refactor/api/translator` --- ### 📝 Commits (2) - [`59f8799`](https://github.com/jtsalva/cloudmare/commit/59f879914d85ebb98c1765ba88a7dc955a8ff34e) refactor translators to use one class - [`b66430c`](https://github.com/jtsalva/cloudmare/commit/b66430c534489815c68b1b60765563481d8b5004) refactor to use new translators ### 📊 Changes **9 files changed** (+91 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/dev/jtsalva/cloudmare/SettingsActivity.kt` (+4 -13) ➕ `app/src/main/java/dev/jtsalva/cloudmare/api/IdTranslator.kt` (+9 -0) 📝 `app/src/main/java/dev/jtsalva/cloudmare/api/dns/DNSRecord.kt` (+39 -45) 📝 `app/src/main/java/dev/jtsalva/cloudmare/api/zonesettings/ZoneSetting.kt` (+29 -49) 📝 `app/src/main/java/dev/jtsalva/cloudmare/viewmodel/CachingViewModel.kt` (+3 -3) 📝 `app/src/main/java/dev/jtsalva/cloudmare/viewmodel/DNSRecordViewModel.kt` (+2 -2) 📝 `app/src/main/java/dev/jtsalva/cloudmare/viewmodel/NetworkViewModel.kt` (+3 -2) 📝 `app/src/main/java/dev/jtsalva/cloudmare/viewmodel/SSLViewModel.kt` (+1 -1) 📝 `app/src/main/java/dev/jtsalva/cloudmare/viewmodel/SettingsViewModel.kt` (+1 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 01:35:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cloudmare-jtsalva#11
No description provided.