[PR #735] [MERGED] fix: require explicit 'true' value for debug mode in deployment #729

Closed
opened 2026-02-26 21:32:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dreamhunter2333/cloudflare_temp_email/pull/735
Author: @dreamhunter2333
Created: 9/26/2025
Status: Merged
Merged: 9/26/2025
Merged by: @dreamhunter2333

Base: mainHead: feature/email


📝 Commits (1)

  • 3062734 fix: require explicit 'true' value for debug mode in deployment

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 .github/workflows/backend_deploy.yaml (+1 -1)

📄 Description

User description

  • Update GitHub Actions workflow to only enable debug mode when DEBUG_MODE secret is exactly 'true'
  • Previously debug mode was enabled for any non-empty value, which could lead to accidental activation
  • Change from [ -n "$debug_mode" ] to [ "$debug_mode" = "true" ] for precise control

🤖 Generated with Claude Code

#732


PR Type

Bug fix, Other


Description

  • Fix GitHub Actions debug mode to require explicit true value.

  • Prevent accidental debug mode activation from non-empty values.

  • Update deployment script for precise control of debug mode.


Changes walkthrough 📝

Relevant files
Bug fix
backend_deploy.yaml
Enforce explicit `true` for debug mode in workflow             

.github/workflows/backend_deploy.yaml

  • Changed debug mode condition to require true value.
  • Prevented accidental activation of debug mode with non-empty values.
  • Updated deployment script for better control.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.

  • 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

    ## 📋 Pull Request Information **Original PR:** https://github.com/dreamhunter2333/cloudflare_temp_email/pull/735 **Author:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Created:** 9/26/2025 **Status:** ✅ Merged **Merged:** 9/26/2025 **Merged by:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Base:** `main` ← **Head:** `feature/email` --- ### 📝 Commits (1) - [`3062734`](https://github.com/dreamhunter2333/cloudflare_temp_email/commit/30627348fb2ede51c442fe47365a69f57a51bda5) fix: require explicit 'true' value for debug mode in deployment ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/backend_deploy.yaml` (+1 -1) </details> ### 📄 Description ### **User description** - Update GitHub Actions workflow to only enable debug mode when DEBUG_MODE secret is exactly 'true' - Previously debug mode was enabled for any non-empty value, which could lead to accidental activation - Change from `[ -n "$debug_mode" ]` to `[ "$debug_mode" = "true" ]` for precise control 🤖 Generated with [Claude Code](https://claude.ai/code) #732 ___ ### **PR Type** Bug fix, Other ___ ### **Description** - Fix GitHub Actions debug mode to require explicit `true` value. - Prevent accidental debug mode activation from non-empty values. - Update deployment script for precise control of debug mode. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>backend_deploy.yaml</strong><dd><code>Enforce explicit `true` for debug mode in workflow</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> .github/workflows/backend_deploy.yaml <li>Changed debug mode condition to require <code>true</code> value.<br> <li> Prevented accidental activation of debug mode with non-empty values.<br> <li> Updated deployment script for better control. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/735/files#diff-9c6ad7c4157d025017a135866a4e838aadda6f903124e4a5d4d632f78c8d5cbe">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
    kerem 2026-02-26 21:32:42 +03:00
    Sign in to join this conversation.
    No milestone
    No project
    No assignees
    1 participant
    Notifications
    Due date
    The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

    No due date set.

    Dependencies

    No dependencies set.

    Reference
    starred/cloudflare_temp_email#729
    No description provided.