[PR #625] [MERGED] feat: s3 attachment add delete #663

New issue

Closed

opened 2026-02-26 21:32:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:32:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dreamhunter2333/cloudflare_temp_email/pull/625
Author: @dreamhunter2333
Created: 4/7/2025
Status: ✅ Merged
Merged: 4/7/2025
Merged by: @dreamhunter2333

Base: main ← Head: feature/dev

📝 Commits (1)

292ac45 feat: s3 attachment add delete

📊 Changes

4 files changed (+51 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 frontend/src/views/index/Attachment.vue (+35 -0)
📝 worker/src/mails_api/index.ts (+1 -0)
📝 worker/src/mails_api/s3_attachment.ts (+14 -1)

📄 Description

User description

#624

PR Type

enhancement

Description

Added delete functionality for S3 attachments.
Integrated delete confirmation dialog in the frontend.
Updated API to handle S3 delete requests.
Documented new feature in the changelog.

Changes walkthrough 📝

Relevant files

Enhancement

Attachment.vue `Add delete button and confirmation dialog` frontend/src/views/index/Attachment.vue Added delete button with confirmation dialog. Integrated API call to delete S3 attachment. Updated localization strings for delete functionality.	+35/-0
index.ts `Add delete endpoint for S3 attachments` worker/src/mails_api/index.ts Added new API endpoint for deleting S3 attachments.	+1/-0
s3_attachment.ts `Implement deleteKey function for S3 objects` worker/src/mails_api/s3_attachment.ts Implemented deleteKey function to delete S3 objects. Imported DeleteObjectCommand from AWS SDK.	+14/-1

Documentation

CHANGELOG.md

Document S3 attachment delete feature

CHANGELOG.md

Documented the addition of S3 attachment delete functionality.

+1/-0

Need help?
Type /help how to ... in the comments thread for any questions about PR-Agent usage.
Check out the documentation for more information.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dreamhunter2333/cloudflare_temp_email/pull/625 **Author:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Created:** 4/7/2025 **Status:** ✅ Merged **Merged:** 4/7/2025 **Merged by:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Base:** `main` ← **Head:** `feature/dev` --- ### 📝 Commits (1) - [`292ac45`](https://github.com/dreamhunter2333/cloudflare_temp_email/commit/292ac45685e7698346990c86fb9aa77b33f74d3c) feat: s3 attachment add delete ### 📊 Changes **4 files changed** (+51 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `frontend/src/views/index/Attachment.vue` (+35 -0) 📝 `worker/src/mails_api/index.ts` (+1 -0) 📝 `worker/src/mails_api/s3_attachment.ts` (+14 -1) </details> ### 📄 Description ### **User description** #624 ___ ### **PR Type** enhancement ___ ### **Description** - Added delete functionality for S3 attachments. - Integrated delete confirmation dialog in the frontend. - Updated API to handle S3 delete requests. - Documented new feature in the changelog. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>Attachment.vue</strong><dd><code>Add delete button and confirmation dialog</code>                                </dd></summary> <hr> frontend/src/views/index/Attachment.vue <li>Added delete button with confirmation dialog.<br> <li> Integrated API call to delete S3 attachment.<br> <li> Updated localization strings for delete functionality. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/625/files#diff-8805f40d2d50697f50fe9f2883edd3a45c120a49342a6e943448b6bf5765c389">+35/-0</a>    </td> </tr> <tr> <td> <details> <summary><strong>index.ts</strong><dd><code>Add delete endpoint for S3 attachments</code>                                      </dd></summary> <hr> worker/src/mails_api/index.ts - Added new API endpoint for deleting S3 attachments. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/625/files#diff-83710df6a60b2b512e134f32ad9890ab9a255040f6019f0d5603f72f4561cea4">+1/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>s3_attachment.ts</strong><dd><code>Implement deleteKey function for S3 objects</code>                            </dd></summary> <hr> worker/src/mails_api/s3_attachment.ts <li>Implemented deleteKey function to delete S3 objects.<br> <li> Imported DeleteObjectCommand from AWS SDK. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/625/files#diff-fa693f011312a68fc5052bda113144dfbee26b9b6dd1ba53c8b863c1f214ac4d">+14/-1</a>    </td> </tr> </table></td></tr><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>CHANGELOG.md</strong><dd><code>Document S3 attachment delete feature</code>                                        </dd></summary> <hr> CHANGELOG.md - Documented the addition of S3 attachment delete functionality. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/625/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed">+1/-0</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>