[PR #419] [MERGED] fix: UI admin page show modal when no need password #571

New issue

Closed

opened 2026-02-26 21:31:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:31:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dreamhunter2333/cloudflare_temp_email/pull/419
Author: @dreamhunter2333
Created: 8/17/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @dreamhunter2333

Base: main ← Head: feature/dev

📝 Commits (1)

90d06fb fix: UI admin page show modal when no need password

📊 Changes

2 files changed (+9 additions, -9 deletions)

View changed files

📝 frontend/src/views/Admin.vue (+8 -8)
📝 frontend/src/views/Header.vue (+1 -1)

📄 Description

User description

#390

PR Type

Bug fix, Enhancement

Description

Fixed the issue where the admin page showed a modal unnecessarily when no password was needed.
Enhanced the admin authentication modal by introducing a computed property showAdminPasswordModal.
Changed the input type to password with show-password-on attribute in both Admin.vue and Header.vue.

Changes walkthrough 📝

Relevant files

Enhancement

Admin.vue `Fix and enhance admin authentication modal behavior` frontend/src/views/Admin.vue Added `computed` import from `vue`. Introduced `showAdminPasswordModal` computed property. Replaced direct `adminAuth` binding with `tmpAdminAuth`. Changed input type to `password` with `show-password-on` attribute.	+8/-8
Header.vue `Update authentication input type in header modal` frontend/src/views/Header.vue Changed input type to `password` with `show-password-on` attribute.	+1/-1

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dreamhunter2333/cloudflare_temp_email/pull/419 **Author:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Created:** 8/17/2024 **Status:** ✅ Merged **Merged:** 8/17/2024 **Merged by:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Base:** `main` ← **Head:** `feature/dev` --- ### 📝 Commits (1) - [`90d06fb`](https://github.com/dreamhunter2333/cloudflare_temp_email/commit/90d06fb3685580832ee1045b086da46d5df8117d) fix: UI admin page show modal when no need password ### 📊 Changes **2 files changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/views/Admin.vue` (+8 -8) 📝 `frontend/src/views/Header.vue` (+1 -1) </details> ### 📄 Description ### **User description** #390 ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Fixed the issue where the admin page showed a modal unnecessarily when no password was needed. - Enhanced the admin authentication modal by introducing a computed property `showAdminPasswordModal`. - Changed the input type to `password` with `show-password-on` attribute in both `Admin.vue` and `Header.vue`. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>Admin.vue</strong><dd><code>Fix and enhance admin authentication modal behavior</code>            </dd></summary> <hr> frontend/src/views/Admin.vue <li>Added <code>computed</code> import from <code>vue</code>.<br> <li> Introduced <code>showAdminPasswordModal</code> computed property.<br> <li> Replaced direct <code>adminAuth</code> binding with <code>tmpAdminAuth</code>.<br> <li> Changed input type to <code>password</code> with <code>show-password-on</code> attribute.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/419/files#diff-78137b072a7fa52c6d503efb9a3d32c07da5073dd5ca32ac48b1402ac2481a55">+8/-8</a>      </td> </tr> <tr> <td> <details> <summary><strong>Header.vue</strong><dd><code>Update authentication input type in header modal</code>                  </dd></summary> <hr> frontend/src/views/Header.vue <li>Changed input type to <code>password</code> with <code>show-password-on</code> attribute.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/419/files#diff-a80b3d70a6be259910c988c05d497228b10a5e686042743c1831584fb391360d">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>