[PR #418] [MERGED] fix: UI admin page show modal when no need password #570

New issue

Closed

opened 2026-02-26 21:31:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:31:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dreamhunter2333/cloudflare_temp_email/pull/418
Author: @dreamhunter2333
Created: 8/17/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @dreamhunter2333

Base: main ← Head: feature/dev

📝 Commits (1)

2a77547 fix: UI admin page show modal when no need password

📊 Changes

3 files changed (+4 additions, -3 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 frontend/src/views/Admin.vue (+2 -2)
📝 frontend/src/views/admin/Account.vue (+1 -1)

📄 Description

PR Type

Bug fix, Documentation

Description

Reordered the user ID fetch logic in Admin.vue to ensure it is executed before checking the showAdminPage condition.
Removed the unused showAdminAuth import in Account.vue.
Updated CHANGELOG.md to include an entry for the admin page password prompt fix.

Changes walkthrough 📝

Relevant files

Bug fix

Admin.vue `Fix user ID fetch logic in Admin page` frontend/src/views/Admin.vue Reordered the user ID fetch logic to ensure it is executed before checking the `showAdminPage` condition.	+2/-2
Account.vue Remove unused `showAdminAuth` import in Account page frontend/src/views/admin/Account.vue Removed the `showAdminAuth` import as it is no longer used.	+1/-1

Documentation

CHANGELOG.md

Update changelog for admin page password prompt fix

CHANGELOG.md

Added an entry for the fix related to the admin page password prompt
issue.

+1/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dreamhunter2333/cloudflare_temp_email/pull/418 **Author:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Created:** 8/17/2024 **Status:** ✅ Merged **Merged:** 8/17/2024 **Merged by:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Base:** `main` ← **Head:** `feature/dev` --- ### 📝 Commits (1) - [`2a77547`](https://github.com/dreamhunter2333/cloudflare_temp_email/commit/2a7754791d38b18806c63faa815c6d0d44f48d41) fix: UI admin page show modal when no need password ### 📊 Changes **3 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `frontend/src/views/Admin.vue` (+2 -2) 📝 `frontend/src/views/admin/Account.vue` (+1 -1) </details> ### 📄 Description ### **PR Type** Bug fix, Documentation ___ ### **Description** - Reordered the user ID fetch logic in `Admin.vue` to ensure it is executed before checking the `showAdminPage` condition. - Removed the unused `showAdminAuth` import in `Account.vue`. - Updated `CHANGELOG.md` to include an entry for the admin page password prompt fix. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>Admin.vue</strong><dd><code>Fix user ID fetch logic in Admin page</code>                                        </dd></summary> <hr> frontend/src/views/Admin.vue <li>Reordered the user ID fetch logic to ensure it is executed before <br>checking the <code>showAdminPage</code> condition.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/418/files#diff-78137b072a7fa52c6d503efb9a3d32c07da5073dd5ca32ac48b1402ac2481a55">+2/-2</a>      </td> </tr> <tr> <td> <details> <summary><strong>Account.vue</strong><dd><code>Remove unused `showAdminAuth` import in Account page</code>          </dd></summary> <hr> frontend/src/views/admin/Account.vue - Removed the `showAdminAuth` import as it is no longer used. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/418/files#diff-1ac8a75932c8a510449efbe046700149bce141b9a325b770922eeaa3486a3d66">+1/-1</a>      </td> </tr> </table></td></tr><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>CHANGELOG.md</strong><dd><code>Update changelog for admin page password prompt fix</code>            </dd></summary> <hr> CHANGELOG.md <li>Added an entry for the fix related to the admin page password prompt <br>issue.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/418/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed">+1/-0</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>