[PR #416] [MERGED] fix: UI tab active icon wrong position #568

New issue

Closed

opened 2026-02-26 21:31:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:31:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416
Author: @dreamhunter2333
Created: 8/16/2024
Status: ✅ Merged
Merged: 8/16/2024
Merged by: @dreamhunter2333

Base: main ← Head: feature/dev

📝 Commits (1)

4905d34 fix: UI tab active icon wrong position

📊 Changes

10 files changed (+22 additions, -20 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 frontend/src/api/index.js (+4 -0)
📝 frontend/src/store/index.js (+2 -0)
📝 frontend/src/views/admin/UserSettings.vue (+5 -4)
📝 frontend/src/views/admin/Webhook.vue (+6 -1)
📝 frontend/src/views/common/Login.vue (+1 -1)
📝 frontend/src/views/user/UserLogin.vue (+1 -1)
📝 worker/src/admin_api/mail_webhook_settings.ts (+0 -7)
📝 worker/src/mails_api/webhook_settings.ts (+0 -6)
📝 worker/src/worker.ts (+2 -0)

📄 Description

PR Type

Bug fix, Enhancement

Description

Added conditional rendering for input fields in UserSettings.vue based on checkbox states.
Introduced webhookEnabled state and conditional rendering in Webhook.vue.
Added conditional rendering for tabs in Login.vue and UserLogin.vue based on settings fetched status.
Removed checks for KV availability and webhook enablement in mail_webhook_settings.ts and webhook_settings.ts.
Updated middleware in worker.ts to include /admin/mail_webhook path.
Ensured settings fetched flag is set in getOpenSettings and getUserOpenSettings functions.
Added fetched flag to openSettings and userOpenSettings states in the store.
Updated changelog to include UI tab active icon position fix.

Changes walkthrough 📝

Relevant files

Enhancement

9 files

UserSettings.vue `Conditional rendering for input fields in UserSettings` frontend/src/views/admin/UserSettings.vue Added conditional rendering for `n-input` and `n-select` based on checkbox states.	+5/-4
Webhook.vue `Webhook settings conditional rendering and translations` frontend/src/views/admin/Webhook.vue Added new translation keys for webhook status. Introduced `webhookEnabled` state to control rendering. Display `n-result` when webhook is not enabled.	+6/-1
Login.vue `Conditional rendering for tabs in Login view` frontend/src/views/common/Login.vue Added conditional rendering for `n-tabs` based on `openSettings.fetched`.	+1/-1
UserLogin.vue `Conditional rendering for tabs in UserLogin view` frontend/src/views/user/UserLogin.vue Added conditional rendering for `n-tabs` based on `userOpenSettings.fetched`.	+1/-1
mail_webhook_settings.ts `Simplified mail webhook settings retrieval` worker/src/admin_api/mail_webhook_settings.ts Removed checks for KV availability and webhook enablement.	+0/-7
webhook_settings.ts `Simplified webhook settings retrieval` worker/src/mails_api/webhook_settings.ts Removed checks for KV availability and webhook enablement.	+0/-6
worker.ts `Middleware update for mail webhook path` worker/src/worker.ts Added check for `/admin/mail_webhook` path in middleware.	+2/-0
index.js `Ensure settings fetched flag is set` frontend/src/api/index.js Set `fetched` flag to true in `getOpenSettings` and `getUserOpenSettings` finally blocks.	+4/-0
index.js `Added fetched flag to settings states` frontend/src/store/index.js Added `fetched` flag to `openSettings` and `userOpenSettings` states.	+2/-0

Documentation

1 files

CHANGELOG.md

Update changelog for UI tab fix

CHANGELOG.md

Added entry for UI tab active icon position fix.

+1/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416 **Author:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Created:** 8/16/2024 **Status:** ✅ Merged **Merged:** 8/16/2024 **Merged by:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Base:** `main` ← **Head:** `feature/dev` --- ### 📝 Commits (1) - [`4905d34`](https://github.com/dreamhunter2333/cloudflare_temp_email/commit/4905d343c11962c668ca39c803d5a3c86e7697a4) fix: UI tab active icon wrong position ### 📊 Changes **10 files changed** (+22 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `frontend/src/api/index.js` (+4 -0) 📝 `frontend/src/store/index.js` (+2 -0) 📝 `frontend/src/views/admin/UserSettings.vue` (+5 -4) 📝 `frontend/src/views/admin/Webhook.vue` (+6 -1) 📝 `frontend/src/views/common/Login.vue` (+1 -1) 📝 `frontend/src/views/user/UserLogin.vue` (+1 -1) 📝 `worker/src/admin_api/mail_webhook_settings.ts` (+0 -7) 📝 `worker/src/mails_api/webhook_settings.ts` (+0 -6) 📝 `worker/src/worker.ts` (+2 -0) </details> ### 📄 Description ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Added conditional rendering for input fields in `UserSettings.vue` based on checkbox states. - Introduced `webhookEnabled` state and conditional rendering in `Webhook.vue`. - Added conditional rendering for tabs in `Login.vue` and `UserLogin.vue` based on settings fetched status. - Removed checks for KV availability and webhook enablement in `mail_webhook_settings.ts` and `webhook_settings.ts`. - Updated middleware in `worker.ts` to include `/admin/mail_webhook` path. - Ensured settings fetched flag is set in `getOpenSettings` and `getUserOpenSettings` functions. - Added `fetched` flag to `openSettings` and `userOpenSettings` states in the store. - Updated changelog to include UI tab active icon position fix. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><details><summary>9 files</summary><table> <tr> <td> <details> <summary><strong>UserSettings.vue</strong><dd><code>Conditional rendering for input fields in UserSettings</code>      </dd></summary> <hr> frontend/src/views/admin/UserSettings.vue <li>Added conditional rendering for <code>n-input</code> and <code>n-select</code> based on checkbox <br>states.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-a98f69fcb5511514645cc9fa9da3b2df48f6f7642526e8bd05e0912414bbded0">+5/-4</a>      </td> </tr> <tr> <td> <details> <summary><strong>Webhook.vue</strong><dd><code>Webhook settings conditional rendering and translations</code>    </dd></summary> <hr> frontend/src/views/admin/Webhook.vue <li>Added new translation keys for webhook status.<br> <li> Introduced <code>webhookEnabled</code> state to control rendering.<br> <li> Display <code>n-result</code> when webhook is not enabled.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-73c78d0a7baed0bfc95c8031d71ab17506f7476cb44f3e00af1cfbea1f2e730b">+6/-1</a>      </td> </tr> <tr> <td> <details> <summary><strong>Login.vue</strong><dd><code>Conditional rendering for tabs in Login view</code>                          </dd></summary> <hr> frontend/src/views/common/Login.vue <li>Added conditional rendering for <code>n-tabs</code> based on <code>openSettings.fetched</code>.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-0ee87c9358b6449242c09bd98ae1ad3a88fb9948c0fcc64c4db3d43e5ec83b4e">+1/-1</a>      </td> </tr> <tr> <td> <details> <summary><strong>UserLogin.vue</strong><dd><code>Conditional rendering for tabs in UserLogin view</code>                  </dd></summary> <hr> frontend/src/views/user/UserLogin.vue <li>Added conditional rendering for <code>n-tabs</code> based on <br><code>userOpenSettings.fetched</code>.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-682df0c783a2d925a33928df3ff3e1d30af7937055f95cb3fcb0d26c156e228c">+1/-1</a>      </td> </tr> <tr> <td> <details> <summary><strong>mail_webhook_settings.ts</strong><dd><code>Simplified mail webhook settings retrieval</code>                              </dd></summary> <hr> worker/src/admin_api/mail_webhook_settings.ts - Removed checks for KV availability and webhook enablement. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-a8888cea638671df084f06f14c82a84294903585f3a218161847b0a96d044821">+0/-7</a>      </td> </tr> <tr> <td> <details> <summary><strong>webhook_settings.ts</strong><dd><code>Simplified webhook settings retrieval</code>                                        </dd></summary> <hr> worker/src/mails_api/webhook_settings.ts - Removed checks for KV availability and webhook enablement. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-0c4fdb3ef2a70f77455a6458c649932abb800e668143eb85d12c95ef911bfb37">+0/-6</a>      </td> </tr> <tr> <td> <details> <summary><strong>worker.ts</strong><dd><code>Middleware update for mail webhook path</code>                                    </dd></summary> <hr> worker/src/worker.ts - Added check for `/admin/mail_webhook` path in middleware. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-c007030a206d7e4e2a4879ba673551e7633ad914b67cfac204096edced3f80a2">+2/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>index.js</strong><dd><code>Ensure settings fetched flag is set</code>                                            </dd></summary> <hr> frontend/src/api/index.js <li>Set <code>fetched</code> flag to true in <code>getOpenSettings</code> and <code>getUserOpenSettings</code> <br>finally blocks.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-80f7e17c8e1f299b7316ce792286ebcaab67ed3afc050e3c5019ed33ab61b34b">+4/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>index.js</strong><dd><code>Added fetched flag to settings states</code>                                        </dd></summary> <hr> frontend/src/store/index.js <li>Added <code>fetched</code> flag to <code>openSettings</code> and <code>userOpenSettings</code> states.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-0c36ce15651c51795b411359e8caaf5af7960c82674b4f2015b8dd5f480fde2c">+2/-0</a>      </td> </tr> </table></details></td></tr><tr><td><strong>Documentation</strong></td><td><details><summary>1 files</summary><table> <tr> <td> <details> <summary><strong>CHANGELOG.md</strong><dd><code>Update changelog for UI tab fix</code>                                                    </dd></summary> <hr> CHANGELOG.md - Added entry for UI tab active icon position fix. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/416/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed">+1/-0</a>      </td> </tr> </table></details></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>