[PR #400] [MERGED] fix: NO_LIMIT_SEND_ROLE no access token #560

Closed
opened 2026-02-26 21:31:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dreamhunter2333/cloudflare_temp_email/pull/400
Author: @dreamhunter2333
Created: 8/12/2024
Status: Merged
Merged: 8/12/2024
Merged by: @dreamhunter2333

Base: mainHead: feature/dev


📝 Commits (1)

  • abe28da fix: NO_LIMIT_SEND_ROLE no access token

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 CHANGELOG.md (+1 -1)
📝 worker/src/user_api/settings.ts (+2 -2)

📄 Description

User description

#391


PR Type

Bug fix, Documentation


Description

  • Fixed the access token generation logic to use the user role directly instead of checking for admin status.
  • Updated the changelog to reflect the fix for the NO_LIMIT_SEND_ROLE configuration loading issue.

Changes walkthrough 📝

Relevant files
Bug fix
settings.ts
Fix access token generation based on user role                     

worker/src/user_api/settings.ts

  • Modified the condition to generate an access token based on user role
    instead of admin status.
  • Ensured user_role is checked directly for token generation.
  • +2/-2     
    Documentation
    CHANGELOG.md
    Update changelog for NO_LIMIT_SEND_ROLE fix                           

    CHANGELOG.md

  • Updated changelog entry for NO_LIMIT_SEND_ROLE configuration fix.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions


    🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

    ## 📋 Pull Request Information **Original PR:** https://github.com/dreamhunter2333/cloudflare_temp_email/pull/400 **Author:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Created:** 8/12/2024 **Status:** ✅ Merged **Merged:** 8/12/2024 **Merged by:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Base:** `main` ← **Head:** `feature/dev` --- ### 📝 Commits (1) - [`abe28da`](https://github.com/dreamhunter2333/cloudflare_temp_email/commit/abe28dadd94e42349136da8b6789c887e66d1657) fix: NO_LIMIT_SEND_ROLE no access token ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -1) 📝 `worker/src/user_api/settings.ts` (+2 -2) </details> ### 📄 Description ### **User description** #391 ___ ### **PR Type** Bug fix, Documentation ___ ### **Description** - Fixed the access token generation logic to use the user role directly instead of checking for admin status. - Updated the changelog to reflect the fix for the `NO_LIMIT_SEND_ROLE` configuration loading issue. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>settings.ts</strong><dd><code>Fix access token generation based on user role</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> worker/src/user_api/settings.ts <li>Modified the condition to generate an access token based on user role <br>instead of admin status.<br> <li> Ensured <code>user_role</code> is checked directly for token generation.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/400/files#diff-0e41b1cd8b40c15de837bee6cf774f29499e490f0b565b0f5556b549f7344dd3">+2/-2</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>CHANGELOG.md</strong><dd><code>Update changelog for NO_LIMIT_SEND_ROLE fix</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> CHANGELOG.md <li>Updated changelog entry for <code>NO_LIMIT_SEND_ROLE</code> configuration fix.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/400/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
    kerem 2026-02-26 21:31:48 +03:00
    Sign in to join this conversation.
    No milestone
    No project
    No assignees
    1 participant
    Notifications
    Due date
    The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

    No due date set.

    Dependencies

    No dependencies set.

    Reference
    starred/cloudflare_temp_email#560
    No description provided.