[PR #396] [MERGED] fix: NO_LIMIT_SEND_ROLE when user settings not call #559

Closed
opened 2026-02-26 21:31:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dreamhunter2333/cloudflare_temp_email/pull/396
Author: @dreamhunter2333
Created: 8/11/2024
Status: Merged
Merged: 8/11/2024
Merged by: @dreamhunter2333

Base: mainHead: feature/dev


📝 Commits (1)

  • a4d3c4d fix: NO_LIMIT_SEND_ROLE when user settings not call

📊 Changes

5 files changed (+13 additions, -4 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 frontend/package.json (+1 -1)
📝 frontend/src/views/Admin.vue (+4 -1)
📝 frontend/src/views/index/SendMail.vue (+3 -1)
📝 worker/src/constants.ts (+1 -1)

📄 Description

User description

#391


PR Type

Bug fix, Enhancement


Description

  • Added checks to ensure user settings are fetched if user_id is not available on both admin and send mail pages.
  • Updated worker and frontend package versions to v0.7.2.
  • Updated CHANGELOG to reflect changes in version v0.7.2.

Changes walkthrough 📝

Relevant files
Enhancement
Admin.vue
Ensure user settings are fetched on admin page load           

frontend/src/views/Admin.vue

  • Imported api module.
  • Added check to fetch user settings if user_id is not available.
  • +4/-1     
    SendMail.vue
    Ensure user settings are fetched on send mail page load   

    frontend/src/views/index/SendMail.vue

    • Added check to fetch user settings if user_id is not available.
    +3/-1     
    Miscellaneous
    constants.ts
    Update worker version to v0.7.2                                                   

    worker/src/constants.ts

    • Updated version from v0.7.1 to v0.7.2.
    +1/-1     
    package.json
    Bump frontend package version to 0.7.2                                     

    frontend/package.json

    • Updated version from 0.7.1 to 0.7.2.
    +1/-1     
    Documentation
    CHANGELOG.md
    Update CHANGELOG for version v0.7.2                                           

    CHANGELOG.md

    • Added entry for version v0.7.2 with bug fix details.
    +4/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions


    🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

    ## 📋 Pull Request Information **Original PR:** https://github.com/dreamhunter2333/cloudflare_temp_email/pull/396 **Author:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Created:** 8/11/2024 **Status:** ✅ Merged **Merged:** 8/11/2024 **Merged by:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Base:** `main` ← **Head:** `feature/dev` --- ### 📝 Commits (1) - [`a4d3c4d`](https://github.com/dreamhunter2333/cloudflare_temp_email/commit/a4d3c4d02017d13b9664e8f6fddff83bf3f3853a) fix: NO_LIMIT_SEND_ROLE when user settings not call ### 📊 Changes **5 files changed** (+13 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `frontend/package.json` (+1 -1) 📝 `frontend/src/views/Admin.vue` (+4 -1) 📝 `frontend/src/views/index/SendMail.vue` (+3 -1) 📝 `worker/src/constants.ts` (+1 -1) </details> ### 📄 Description ### **User description** #391 ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Added checks to ensure user settings are fetched if `user_id` is not available on both admin and send mail pages. - Updated worker and frontend package versions to `v0.7.2`. - Updated CHANGELOG to reflect changes in version `v0.7.2`. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>Admin.vue</strong><dd><code>Ensure user settings are fetched on admin page load</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> frontend/src/views/Admin.vue <li>Imported <code>api</code> module.<br> <li> Added check to fetch user settings if <code>user_id</code> is not available.<br> </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/396/files#diff-78137b072a7fa52c6d503efb9a3d32c07da5073dd5ca32ac48b1402ac2481a55">+4/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td> <details> <summary><strong>SendMail.vue</strong><dd><code>Ensure user settings are fetched on send mail page load</code>&nbsp; &nbsp; </dd></summary> <hr> frontend/src/views/index/SendMail.vue - Added check to fetch user settings if `user_id` is not available. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/396/files#diff-005668289e156e6ef43ee2b7d75f8592c1db57e9ecfc1dd7656e5ab19526a380">+3/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr><tr><td><strong>Miscellaneous</strong></td><td><table> <tr> <td> <details> <summary><strong>constants.ts</strong><dd><code>Update worker version to v0.7.2</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> worker/src/constants.ts - Updated version from `v0.7.1` to `v0.7.2`. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/396/files#diff-cab08ba19c1499ed426fc4918a5613e22eb95c3427c7467ce330f5ee0d69d01e">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> <tr> <td> <details> <summary><strong>package.json</strong><dd><code>Bump frontend package version to 0.7.2</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> frontend/package.json - Updated version from `0.7.1` to `0.7.2`. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/396/files#diff-da6498268e99511d9ba0df3c13e439d10556a812881c9d03955b2ef7c6c1c655">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>CHANGELOG.md</strong><dd><code>Update CHANGELOG for version v0.7.2</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> CHANGELOG.md - Added entry for version `v0.7.2` with bug fix details. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/396/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed">+4/-0</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
    kerem 2026-02-26 21:31:47 +03:00
    Sign in to join this conversation.
    No milestone
    No project
    No assignees
    1 participant
    Notifications
    Due date
    The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

    No due date set.

    Dependencies

    No dependencies set.

    Reference
    starred/cloudflare_temp_email#559
    No description provided.