[PR #371] [MERGED] feat: add SHOW_GITHUB config #550

New issue

Closed

opened 2026-02-26 21:31:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:31:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371
Author: @dreamhunter2333
Created: 8/4/2024
Status: ✅ Merged
Merged: 8/4/2024
Merged by: @dreamhunter2333

Base: main ← Head: feature/dev

📝 Commits (1)

b9b9c3c feat: add SHOW_GITHUB config

📊 Changes

7 files changed (+7 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 frontend/src/views/Header.vue (+1 -0)
📝 vitepress-docs/docs/en/cli.md (+1 -0)
📝 vitepress-docs/docs/zh/guide/cli/worker.md (+1 -0)
📝 worker/src/commom_api.ts (+1 -0)
📝 worker/src/types.d.ts (+1 -0)
📝 worker/wrangler.toml.template (+1 -0)

📄 Description

User description

#368

PR Type

Enhancement, Documentation

Description

Added SHOW_GITHUB configuration to control the visibility of the GitHub link in the frontend.
Updated the settings API to include the showGithub parameter.
Documented the new SHOW_GITHUB configuration in both English and Chinese documentation.
Updated the changelog to reflect the addition of the SHOW_GITHUB configuration.

Changes walkthrough 📝

Relevant files

Enhancement

Header.vue `Add conditional visibility for GitHub menu option` frontend/src/views/Header.vue Added `showGithub` condition to GitHub menu option visibility.	+1/-0
commom_api.ts Include `showGithub` in settings API response worker/src/commom_api.ts Added `showGithub` to the settings API response.	+1/-0
types.d.ts Add `SHOW_GITHUB` to `Bindings` type definition worker/src/types.d.ts Added `SHOW_GITHUB` to `Bindings` type definition.	+1/-0

Documentation

CHANGELOG.md Document `SHOW_GITHUB` configuration in changelog CHANGELOG.md Documented the addition of `SHOW_GITHUB` configuration.	+1/-0
cli.md Add `SHOW_GITHUB` configuration documentation (EN) vitepress-docs/docs/en/cli.md Added documentation for `SHOW_GITHUB` configuration.	+1/-0
worker.md Add `SHOW_GITHUB` configuration documentation (ZH) vitepress-docs/docs/zh/guide/cli/worker.md Added documentation for `SHOW_GITHUB` configuration.	+1/-0
wrangler.toml.template Add `SHOW_GITHUB` configuration example worker/wrangler.toml.template Added `SHOW_GITHUB` configuration example.	+1/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371 **Author:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Created:** 8/4/2024 **Status:** ✅ Merged **Merged:** 8/4/2024 **Merged by:** [@dreamhunter2333](https://github.com/dreamhunter2333) **Base:** `main` ← **Head:** `feature/dev` --- ### 📝 Commits (1) - [`b9b9c3c`](https://github.com/dreamhunter2333/cloudflare_temp_email/commit/b9b9c3c24995a4cf5a1692cb917b073737f1e3d0) feat: add SHOW_GITHUB config ### 📊 Changes **7 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `frontend/src/views/Header.vue` (+1 -0) 📝 `vitepress-docs/docs/en/cli.md` (+1 -0) 📝 `vitepress-docs/docs/zh/guide/cli/worker.md` (+1 -0) 📝 `worker/src/commom_api.ts` (+1 -0) 📝 `worker/src/types.d.ts` (+1 -0) 📝 `worker/wrangler.toml.template` (+1 -0) </details> ### 📄 Description ### **User description** #368 ___ ### **PR Type** Enhancement, Documentation ___ ### **Description** - Added `SHOW_GITHUB` configuration to control the visibility of the GitHub link in the frontend. - Updated the settings API to include the `showGithub` parameter. - Documented the new `SHOW_GITHUB` configuration in both English and Chinese documentation. - Updated the changelog to reflect the addition of the `SHOW_GITHUB` configuration. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>Header.vue</strong><dd><code>Add conditional visibility for GitHub menu option</code>                </dd></summary> <hr> frontend/src/views/Header.vue - Added `showGithub` condition to GitHub menu option visibility. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371/files#diff-a80b3d70a6be259910c988c05d497228b10a5e686042743c1831584fb391360d">+1/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>commom_api.ts</strong><dd><code>Include `showGithub` in settings API response</code>                        </dd></summary> <hr> worker/src/commom_api.ts - Added `showGithub` to the settings API response. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371/files#diff-fe2dec25bee7d722fe8aa25b616c21bd12b8123e26469f5cac11c9164be783c3">+1/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>types.d.ts</strong><dd><code>Add `SHOW_GITHUB` to `Bindings` type definition</code>                    </dd></summary> <hr> worker/src/types.d.ts - Added `SHOW_GITHUB` to `Bindings` type definition. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371/files#diff-583fb024d5c9d1efac71bbea788d8379e5e8fc2f0bb1696a9863c6f6cac54bee">+1/-0</a>      </td> </tr> </table></td></tr><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>CHANGELOG.md</strong><dd><code>Document `SHOW_GITHUB` configuration in changelog</code>                </dd></summary> <hr> CHANGELOG.md - Documented the addition of `SHOW_GITHUB` configuration. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed">+1/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>cli.md</strong><dd><code>Add `SHOW_GITHUB` configuration documentation (EN)</code>              </dd></summary> <hr> vitepress-docs/docs/en/cli.md - Added documentation for `SHOW_GITHUB` configuration. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371/files#diff-3f8f72a691fa19c8581621e91cf67ad28855af7a57e58513f6563cf4c8886e5f">+1/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>worker.md</strong><dd><code>Add `SHOW_GITHUB` configuration documentation (ZH)</code>              </dd></summary> <hr> vitepress-docs/docs/zh/guide/cli/worker.md - Added documentation for `SHOW_GITHUB` configuration. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371/files#diff-f760a2ec5dad4b6bda0bd4a9325274567778add8cb984e73650dbaaf680c9178">+1/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>wrangler.toml.template</strong><dd><code>Add `SHOW_GITHUB` configuration example</code>                                    </dd></summary> <hr> worker/wrangler.toml.template - Added `SHOW_GITHUB` configuration example. </details> </td> <td><a href="https://github.com/dreamhunter2333/cloudflare_temp_email/pull/371/files#diff-743273da72481b71fbeb1dddfd294be9249554eef65691dfc9bcfa9f0fd971fb">+1/-0</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>