[PR #4134] ctrl + z is unstable (lib artefact fix) #4709

New issue

Closed

opened 2026-03-07 21:19:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 21:19:31 +03:00

Owner

Original Pull Request: https://github.com/dbeaver/cloudbeaver/pull/4134

State: closed
Merged: No

closes https://github.com/dbeaver/cloudbeaver/issues/3815

The bug is on the lib side. The issue here is that it fires the event handler on almost every key press because it does not account for modifiers (Ctrl, Cmd, Alt, etc.).

What I've done here:

fixed bug and created issue & PR for the library https://github.com/JohannesKlauss/react-hotkeys-hook/issues/1318
Build the lib and these artefacts put them into our codebase
Then, I implemented the fix for the task. Added useKey:true so it parses shortcuts not by the code but for the symbol itself. So, for example, the symbol "s" is the same on any type of keyboard (QWERTY, AZERTY, etc.).

As a third alternative solution, we can just wait for the lib to fix the issue. Then update the lib

**Original Pull Request:** https://github.com/dbeaver/cloudbeaver/pull/4134 **State:** closed **Merged:** No --- closes https://github.com/dbeaver/cloudbeaver/issues/3815 The bug is on the lib side. The issue here is that it fires the event handler on almost every key press because it does not account for modifiers (Ctrl, Cmd, Alt, etc.). What I've done here: 1. fixed bug and created issue & PR for the library https://github.com/JohannesKlauss/react-hotkeys-hook/issues/1318 2. Build the lib and these artefacts put them into our codebase 3. Then, I implemented the fix for the task. Added `useKey:true` so it parses shortcuts not by the code but for the symbol itself. So, for example, the symbol "s" is the same on any type of keyboard (QWERTY, AZERTY, etc.). As a third alternative solution, we can just wait for the lib to fix the issue. Then update the lib