[PR #1324] [MERGED] CB-2706 allow copy from sql editor in readonly mode #2415

Closed
opened 2026-03-07 21:08:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dbeaver/cloudbeaver/pull/1324
Author: @devnaumov
Created: 11/25/2022
Status: Merged
Merged: 11/26/2022
Merged by: @devnaumov

Base: develHead: CB-2706-allow-copy-sql-editor


📝 Commits (2)

  • efba7a4 CB-2706 allow copy from sql editor in readonly mode
  • 8ccaef0 CB-2706 use DEFAULT_CURSOR_BLINK_RATE only in the CodeEditor

📊 Changes

3 files changed (+12 additions, -5 deletions)

View changed files

📝 webapp/packages/plugin-codemirror/src/CodeEditor.tsx (+8 -3)
📝 webapp/packages/plugin-data-viewer/src/ValuePanelPresentation/TextValue/TextValuePresentation.tsx (+2 -1)
📝 webapp/packages/plugin-sql-editor/src/SqlEditor/SQLCodeEditor/SQLCodeEditor.tsx (+2 -1)

📄 Description

You can't focus the editor with the settings 'nocursor', so there is no way to have copy work (browser will only send copy events to focused elements). So we just hide cursor in readonly mode to mimic this behaviour.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dbeaver/cloudbeaver/pull/1324 **Author:** [@devnaumov](https://github.com/devnaumov) **Created:** 11/25/2022 **Status:** ✅ Merged **Merged:** 11/26/2022 **Merged by:** [@devnaumov](https://github.com/devnaumov) **Base:** `devel` ← **Head:** `CB-2706-allow-copy-sql-editor` --- ### 📝 Commits (2) - [`efba7a4`](https://github.com/dbeaver/cloudbeaver/commit/efba7a437ec640810f96699c6feb5321fdc53382) CB-2706 allow copy from sql editor in readonly mode - [`8ccaef0`](https://github.com/dbeaver/cloudbeaver/commit/8ccaef096089ac3237ef783edb5aa2760555fbd5) CB-2706 use DEFAULT_CURSOR_BLINK_RATE only in the CodeEditor ### 📊 Changes **3 files changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `webapp/packages/plugin-codemirror/src/CodeEditor.tsx` (+8 -3) 📝 `webapp/packages/plugin-data-viewer/src/ValuePanelPresentation/TextValue/TextValuePresentation.tsx` (+2 -1) 📝 `webapp/packages/plugin-sql-editor/src/SqlEditor/SQLCodeEditor/SQLCodeEditor.tsx` (+2 -1) </details> ### 📄 Description You can't focus the editor with the settings 'nocursor', so there is no way to have copy work (browser will only send copy events to focused elements). So we just hide cursor in readonly mode to mimic this behaviour. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-07 21:08:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cloudbeaver#2415
No description provided.