mirror of
https://github.com/goodhosts/cli.git
synced 2026-04-27 15:16:00 +03:00
[GH-ISSUE #16] Goodhosts issues on OSX #8
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Mte90 on GitHub (Oct 16, 2020).
Original GitHub issue: https://github.com/goodhosts/cli/issues/16
We are getting some crashes on OSX.
Seems the line with the issue is https://github.com/goodhosts/hostsfile/blob/master/hosts.go#L297
@luthermonson commented on GitHub (Oct 16, 2020):
this is consistent or intermittent? i saw another issue about remove by position, think it's related?
@Mte90 commented on GitHub (Oct 16, 2020):
We have 2 users with this issue, so I am looking to release an old version of the plugin with a previous release.
@tomjn commented on GitHub (Oct 16, 2020):
I downloaded and ran
sudo goodhosts cleanand got the same error:@tomjn commented on GitHub (Oct 16, 2020):
adding and removing is unaffected, it's just the clean operation that has the issue
@tomjn commented on GitHub (Oct 16, 2020):
My hosts file for coomparison:
/etc/host
@luthermonson commented on GitHub (Oct 16, 2020):
i will check with your data and confirm. thanks and sorry about this
@luthermonson commented on GitHub (Oct 16, 2020):
ok so ya this is recreatable with your hostsfile content. im working on a patch and sorry about that
@luthermonson commented on GitHub (Oct 16, 2020):
ok i fixed.. did this on windows so see below with a --dry-run. ill PR in a bit.
@tomjn commented on GitHub (Oct 16, 2020):
awesome :) thanks for such a quick turn around!