[PR #31] [MERGED] Additional Clean flags to target your cleanup #34

New issue

Closed

opened 2026-03-02 05:09:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 05:09:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/goodhosts/cli/pull/31
Author: @luthermonson
Created: 12/1/2021
Status: ✅ Merged
Merged: 12/2/2021
Merged by: @luthermonson

Base: master ← Head: clean-flags

📝 Commits (2)

3f9aba8 add extra flags to choose your cleanup
f23508c vendor

📊 Changes

29 files changed (+4120 additions, -100 deletions)

View changed files

📝 cmd/clean.go (+59 -5)
📝 go.mod (+3 -2)
📝 go.sum (+12 -5)
➕ vendor/github.com/asaskevich/govalidator/.gitignore (+15 -0)
➕ vendor/github.com/asaskevich/govalidator/.travis.yml (+12 -0)
➕ vendor/github.com/asaskevich/govalidator/CODE_OF_CONDUCT.md (+43 -0)
➕ vendor/github.com/asaskevich/govalidator/CONTRIBUTING.md (+63 -0)
➕ vendor/github.com/asaskevich/govalidator/LICENSE (+21 -0)
➕ vendor/github.com/asaskevich/govalidator/README.md (+622 -0)
➕ vendor/github.com/asaskevich/govalidator/arrays.go (+87 -0)
➕ vendor/github.com/asaskevich/govalidator/converter.go (+81 -0)
➕ vendor/github.com/asaskevich/govalidator/doc.go (+3 -0)
➕ vendor/github.com/asaskevich/govalidator/error.go (+47 -0)
➕ vendor/github.com/asaskevich/govalidator/numerics.go (+100 -0)
➕ vendor/github.com/asaskevich/govalidator/patterns.go (+113 -0)
➕ vendor/github.com/asaskevich/govalidator/types.go (+656 -0)
➕ vendor/github.com/asaskevich/govalidator/utils.go (+270 -0)
➕ vendor/github.com/asaskevich/govalidator/validator.go (+1769 -0)
➕ vendor/github.com/asaskevich/govalidator/wercker.yml (+15 -0)
📝 vendor/github.com/dimchansky/utfbom/.travis.yml (+16 -5)

...and 9 more files

📄 Description

cleaning everything was a bit too much of a hammer for some people so we've switched to having a bool flag for each clean and an --all or -A to do the original clean with no args we had previously. due to behavior changing from no args doing the full clean to -A doing the full clean we will ++ the minor release when this is merged

vendor includes v0.0.10 bump of hostsfile which includes the windows fixes for 9 hosts/line.

~\goodhosts\cli [clean-flags] > gc hosts
127.0.0.2 b1 a2
127.0.0.1 host host
~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --si
127.0.0.1 host host
127.0.0.2 b1 a2
~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --sh
127.0.0.2 a2 b1
127.0.0.1 host host
~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --rdh
127.0.0.2 b1 a2
127.0.0.1 host
~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --rdi
127.0.0.2 b1 a2
127.0.0.1 host host
~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --all
127.0.0.1 host
127.0.0.2 a2 b1

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/goodhosts/cli/pull/31 **Author:** [@luthermonson](https://github.com/luthermonson) **Created:** 12/1/2021 **Status:** ✅ Merged **Merged:** 12/2/2021 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `master` ← **Head:** `clean-flags` --- ### 📝 Commits (2) - [`3f9aba8`](https://github.com/goodhosts/cli/commit/3f9aba8537382ffc19251c1af3b2954896c131b7) add extra flags to choose your cleanup - [`f23508c`](https://github.com/goodhosts/cli/commit/f23508cf5f4156260f76e830e5e3dbaa2b82eec8) vendor ### 📊 Changes **29 files changed** (+4120 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `cmd/clean.go` (+59 -5) 📝 `go.mod` (+3 -2) 📝 `go.sum` (+12 -5) ➕ `vendor/github.com/asaskevich/govalidator/.gitignore` (+15 -0) ➕ `vendor/github.com/asaskevich/govalidator/.travis.yml` (+12 -0) ➕ `vendor/github.com/asaskevich/govalidator/CODE_OF_CONDUCT.md` (+43 -0) ➕ `vendor/github.com/asaskevich/govalidator/CONTRIBUTING.md` (+63 -0) ➕ `vendor/github.com/asaskevich/govalidator/LICENSE` (+21 -0) ➕ `vendor/github.com/asaskevich/govalidator/README.md` (+622 -0) ➕ `vendor/github.com/asaskevich/govalidator/arrays.go` (+87 -0) ➕ `vendor/github.com/asaskevich/govalidator/converter.go` (+81 -0) ➕ `vendor/github.com/asaskevich/govalidator/doc.go` (+3 -0) ➕ `vendor/github.com/asaskevich/govalidator/error.go` (+47 -0) ➕ `vendor/github.com/asaskevich/govalidator/numerics.go` (+100 -0) ➕ `vendor/github.com/asaskevich/govalidator/patterns.go` (+113 -0) ➕ `vendor/github.com/asaskevich/govalidator/types.go` (+656 -0) ➕ `vendor/github.com/asaskevich/govalidator/utils.go` (+270 -0) ➕ `vendor/github.com/asaskevich/govalidator/validator.go` (+1769 -0) ➕ `vendor/github.com/asaskevich/govalidator/wercker.yml` (+15 -0) 📝 `vendor/github.com/dimchansky/utfbom/.travis.yml` (+16 -5) _...and 9 more files_ </details> ### 📄 Description cleaning everything was a bit too much of a hammer for some people so we've switched to having a bool flag for each clean and an `--all` or `-A` to do the original clean with no args we had previously. due to behavior changing from no args doing the full clean to -A doing the full clean we will ++ the minor release when this is merged vendor includes v0.0.10 bump of hostsfile which includes the windows fixes for 9 hosts/line. ``` ~\goodhosts\cli [clean-flags] > gc hosts 127.0.0.2 b1 a2 127.0.0.1 host host ~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --si 127.0.0.1 host host 127.0.0.2 b1 a2 ~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --sh 127.0.0.2 a2 b1 127.0.0.1 host host ~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --rdh 127.0.0.2 b1 a2 127.0.0.1 host ~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --rdi 127.0.0.2 b1 a2 127.0.0.1 host host ~\goodhosts\cli [clean-flags] > goodhosts -f ./hosts clean --dry-run --all 127.0.0.1 host 127.0.0.2 a2 b1 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>