[PR #27] [MERGED] Fix/19 #32

New issue

Closed

opened 2026-03-02 05:09:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 05:09:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/goodhosts/cli/pull/27
Author: @tomjn
Created: 1/18/2021
Status: ✅ Merged
Merged: 1/18/2021
Merged by: @luthermonson

Base: master ← Head: fix/19

📝 Commits (4)

ec4d81f don't check if the hostsfile is writable if we only want readonly access
9108e98 adjust all calls of loadHostsfile to specify if they need write or just read access
caab38f add missing parameter to backup.go
2eac19f load the hosts file in read only mode in the debugFooter

📊 Changes

9 files changed (+12 additions, -11 deletions)

View changed files

📝 cmd/add.go (+1 -1)
📝 cmd/backup.go (+1 -1)
📝 cmd/check.go (+1 -1)
📝 cmd/clean.go (+1 -1)
📝 cmd/edit.go (+1 -1)
📝 cmd/list.go (+1 -1)
📝 cmd/main.go (+3 -3)
📝 cmd/remove.go (+2 -1)
📝 cmd/restore.go (+1 -1)

📄 Description

Closes #19 by aallowing loadHostsfile to specify if it needs write access

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/goodhosts/cli/pull/27 **Author:** [@tomjn](https://github.com/tomjn) **Created:** 1/18/2021 **Status:** ✅ Merged **Merged:** 1/18/2021 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `master` ← **Head:** `fix/19` --- ### 📝 Commits (4) - [`ec4d81f`](https://github.com/goodhosts/cli/commit/ec4d81fd61951b11103d620a6f69f5215c7d4e45) don't check if the hostsfile is writable if we only want readonly access - [`9108e98`](https://github.com/goodhosts/cli/commit/9108e98505c8139ce486bafaa55f67ef6868d4c0) adjust all calls of loadHostsfile to specify if they need write or just read access - [`caab38f`](https://github.com/goodhosts/cli/commit/caab38f293e2aa84defb85927f3b372f9d0ab659) add missing parameter to backup.go - [`2eac19f`](https://github.com/goodhosts/cli/commit/2eac19f8b6234cedb1f891f3203a3e9e59a689bd) load the hosts file in read only mode in the debugFooter ### 📊 Changes **9 files changed** (+12 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `cmd/add.go` (+1 -1) 📝 `cmd/backup.go` (+1 -1) 📝 `cmd/check.go` (+1 -1) 📝 `cmd/clean.go` (+1 -1) 📝 `cmd/edit.go` (+1 -1) 📝 `cmd/list.go` (+1 -1) 📝 `cmd/main.go` (+3 -3) 📝 `cmd/remove.go` (+2 -1) 📝 `cmd/restore.go` (+1 -1) </details> ### 📄 Description Closes #19 by aallowing `loadHostsfile` to specify if it needs write access --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>