starred/cli

Fork 0

mirror of https://github.com/goodhosts/cli.git synced 2026-04-27 07:06:00 +03:00

[GH-ISSUE #25] False assumption: IPs appear in a single position #14

New issue

Closed

opened 2026-03-02 05:09:09 +03:00 by kerem · 3 comments

kerem commented

2026-03-02 05:09:09 +03:00

Owner

Originally created by @tomjn on GitHub (Jan 13, 2021).
Original GitHub issue: https://github.com/goodhosts/cli/issues/25

https://github.com/goodhosts/hostsfile/blob/master/hosts.go#L103

The code that adds a host performs a check to see if a line with the IP is already present, and if so, it inspects the hosts on that line and only adds the host if it is not listed.

However, this assumption is not true.

For example, consider this hosts file:

127.0.0.1 tom.test
127.0.0.1 tom.test example.test

Goodhosts will pick up the first line, see that example.test is not present, and add the host, leading to duplication.

Instead, this needs to be a loop, and position := h.getIpPosition(ip) needs to be positions := h.getIpPositions(ip).

Likewise, if an existing entry is present, this code does not remove it, which can lead to hostnames being defined multiple times but with different IPs

Originally created by @tomjn on GitHub (Jan 13, 2021). Original GitHub issue: https://github.com/goodhosts/cli/issues/25 https://github.com/goodhosts/hostsfile/blob/master/hosts.go#L103 The code that adds a host performs a check to see if a line with the IP is already present, and if so, it inspects the hosts on that line and only adds the host if it is not listed. **However, this assumption is not true.** For example, consider this hosts file: ``` 127.0.0.1 tom.test 127.0.0.1 tom.test example.test ``` Goodhosts will pick up the first line, see that `example.test` is not present, and add the host, leading to duplication. Instead, this needs to be a loop, and `position := h.getIpPosition(ip)` needs to be `positions := h.getIpPositions(ip)`. Likewise, if an existing entry is present, this code does not remove it, which can lead to hostnames being defined multiple times but with different IPs

kerem closed this issue

2026-03-02 05:09:10 +03:00

kerem commented

2026-03-02 05:09:10 +03:00

Author

Owner

@tomjn commented on GitHub (Jan 13, 2021):

Likewise getHostPosition getHostPosition and getHostnamePosition need plural versions

@tomjn commented on GitHub (Jan 13, 2021): Likewise `getHostPosition` `getHostPosition` and `getHostnamePosition` need plural versions

kerem commented

2026-03-02 05:09:10 +03:00

Author

Owner

@luthermonson commented on GitHub (Jan 14, 2021):

good find!

@luthermonson commented on GitHub (Jan 14, 2021): good find!

kerem commented

2026-03-02 05:09:10 +03:00

Author

Owner

@tomjn commented on GitHub (Jan 15, 2021):

I notice that in places in the code it uses this and then loops until no instances are found, and in other places it might not do this.

Instead, if it fetched all positions, sorted them from smallest to largest, then worked backwards from the end of the file to the start, we can achieve the same result using these functions. I did start on adding the functions which seemed easy enough, but didn't look into using them, golang isn't super familiar to me. Something like this is what I was thinking:

func (h Hosts) getIpPositions(ip string) []int {
	positions := new [...]int
	for i := range h.Lines {
		line := h.Lines[i]
		if !line.IsComment() && line.Raw != "" && line.IP == ip {
			append(positions, i)
		}
	}

	return positions
}

@tomjn commented on GitHub (Jan 15, 2021): I notice that in places in the code it uses this and then loops until no instances are found, and in other places it might not do this. Instead, if it fetched all positions, sorted them from smallest to largest, then worked backwards from the end of the file to the start, we can achieve the same result using these functions. I did start on adding the functions which seemed easy enough, but didn't look into using them, golang isn't super familiar to me. Something like this is what I was thinking: ```go func (h Hosts) getIpPositions(ip string) []int { positions := new [...]int for i := range h.Lines { line := h.Lines[i] if !line.IsComment() && line.Raw != "" && line.IP == ip { append(positions, i) } } return positions } ```

kerem referenced this issue

2026-03-02 05:09:17 +03:00

[PR #14] [MERGED] Add clean and dry-run to add/remove #26

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/cli#14

No description provided.

Rows
Columns