[PR #621] [MERGED] Fix Azure KeyVault bug & Support custom certificate name in Azure KeyVault #999

New issue

Closed

opened 2026-03-03 01:07:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:07:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/certimate-go/certimate/pull/621
Author: @fondoger
Created: 4/16/2025
Status: ✅ Merged
Merged: 4/19/2025
Merged by: @usual2970

Base: main ← Head: fondoger/keyvault

📝 Commits (3)

364ceb2 Fix Azure KeyVault bug
0004eac Modify code according to code suggestions
283b150 refactor: re-impl azure keyvault deployer

📊 Changes

7 files changed (+233 additions, -11 deletions)

View changed files

📝 internal/deployer/providers.go (+6 -5)
📝 internal/pkg/core/deployer/providers/azure-keyvault/azure_keyvault.go (+104 -4)
📝 internal/pkg/core/uploader/providers/azure-keyvault/azure_keyvault.go (+11 -2)
➕ internal/pkg/core/uploader/providers/azure-keyvault/azure_keyvault_test.go (+87 -0)
📝 ui/src/components/workflow/node/DeployNodeConfigFormAzureKeyVaultConfig.tsx (+17 -0)
📝 ui/src/i18n/locales/en/nls.workflow.nodes.json (+4 -0)
📝 ui/src/i18n/locales/zh/nls.workflow.nodes.json (+4 -0)

📄 Description

fix: https://github.com/usual2970/certimate/issues/619.

PR介绍：

修复 Azure KeyVault 上传证书时，证书私钥漏掉的bug. #619
修复 Azure KeyVault 不支持上传带有证书链的PEM格式证书的bug.
新增 Azure KeyVault 上传证书时，可以指定证书名称的功能.

指定证书名称的例子:

PR 测试成功的证据：

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/certimate-go/certimate/pull/621 **Author:** [@fondoger](https://github.com/fondoger) **Created:** 4/16/2025 **Status:** ✅ Merged **Merged:** 4/19/2025 **Merged by:** [@usual2970](https://github.com/usual2970) **Base:** `main` ← **Head:** `fondoger/keyvault` --- ### 📝 Commits (3) - [`364ceb2`](https://github.com/certimate-go/certimate/commit/364ceb23997bc9972be2f8d2049c81d1eb7a8b2e) Fix Azure KeyVault bug - [`0004eac`](https://github.com/certimate-go/certimate/commit/0004eac764074570e140b1b88641020710e4b8bd) Modify code according to code suggestions - [`283b150`](https://github.com/certimate-go/certimate/commit/283b150d60070cadb8be3aecc822fa6aadf3b8ed) refactor: re-impl azure keyvault deployer ### 📊 Changes **7 files changed** (+233 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `internal/deployer/providers.go` (+6 -5) 📝 `internal/pkg/core/deployer/providers/azure-keyvault/azure_keyvault.go` (+104 -4) 📝 `internal/pkg/core/uploader/providers/azure-keyvault/azure_keyvault.go` (+11 -2) ➕ `internal/pkg/core/uploader/providers/azure-keyvault/azure_keyvault_test.go` (+87 -0) 📝 `ui/src/components/workflow/node/DeployNodeConfigFormAzureKeyVaultConfig.tsx` (+17 -0) 📝 `ui/src/i18n/locales/en/nls.workflow.nodes.json` (+4 -0) 📝 `ui/src/i18n/locales/zh/nls.workflow.nodes.json` (+4 -0) </details> ### 📄 Description fix: https://github.com/usual2970/certimate/issues/619. PR介绍： 1. 修复 Azure KeyVault 上传证书时，证书私钥漏掉的bug. #619 2. 修复 Azure KeyVault 不支持上传带有证书链的PEM格式证书的bug. 3. 新增 Azure KeyVault 上传证书时，可以指定证书名称的功能. 指定证书名称的例子: <img width="599" alt="image" src="https://github.com/user-attachments/assets/324cdcde-2401-4e21-8925-3dfa0323526b" /> PR 测试成功的证据： <img width="1341" alt="image" src="https://github.com/user-attachments/assets/fd7888fe-b5e2-4a3d-95c1-f1f90cb4656e" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>