[PR #340] [MERGED] fix: reapply when domain list changed #926

New issue

Closed

opened 2026-03-03 01:06:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:06:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/certimate-go/certimate/pull/340
Author: @LeoChen98
Created: 11/13/2024
Status: ✅ Merged
Merged: 11/18/2024
Merged by: @usual2970

Base: main ← Head: fix-reapply-when-domain-list-changed

📝 Commits (6)

952e968 fix misspelling var name
41bd321 fixed: not reapply when domain list changed
9a75d2a add key algorithm check
56eced3 Invert the boolean value to match the function name
d1d7b44 Invert the changed logic to match the function name
3265dd7 edit comments for the forward changes

📊 Changes

2 files changed (+83 additions, -5 deletions)

View changed files

📝 internal/deployer/tencent_cdn.go (+3 -3)
📝 internal/domains/deploy.go (+80 -2)

📄 Description

修复修改申请证书的域名后不触发重新申请证书的逻辑的问题（#334 ）

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/certimate-go/certimate/pull/340 **Author:** [@LeoChen98](https://github.com/LeoChen98) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 11/18/2024 **Merged by:** [@usual2970](https://github.com/usual2970) **Base:** `main` ← **Head:** `fix-reapply-when-domain-list-changed` --- ### 📝 Commits (6) - [`952e968`](https://github.com/certimate-go/certimate/commit/952e9687d0e8f1d834c923f679bf76e9eaf19af2) fix misspelling var name - [`41bd321`](https://github.com/certimate-go/certimate/commit/41bd321a4f32c32d6ccf909bfd32d908fe2fb405) fixed: not reapply when domain list changed - [`9a75d2a`](https://github.com/certimate-go/certimate/commit/9a75d2ac8f337421e51855147bd39e24efa072a1) add key algorithm check - [`56eced3`](https://github.com/certimate-go/certimate/commit/56eced3813a345b7159b39ca55318f7b09678337) Invert the boolean value to match the function name - [`d1d7b44`](https://github.com/certimate-go/certimate/commit/d1d7b443033347be92a918dfd9e1ffbdb84c5a10) Invert the changed logic to match the function name - [`3265dd7`](https://github.com/certimate-go/certimate/commit/3265dd76ab18073f78ee83063ad9adacc0e3a1d7) edit comments for the forward changes ### 📊 Changes **2 files changed** (+83 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `internal/deployer/tencent_cdn.go` (+3 -3) 📝 `internal/domains/deploy.go` (+80 -2) </details> ### 📄 Description - 修复修改申请证书的域名后不触发重新申请证书的逻辑的问题（#334 ） --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>