[PR #251] [MERGED] Support create secret, add cert annotations. #884

New issue

Closed

opened 2026-03-03 01:06:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:06:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/certimate-go/certimate/pull/251
Author: @aazf
Created: 10/24/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @usual2970

Base: main ← Head: main

📝 Commits (4)

528a3d9 support create secret, add cert annotations.
9f6ea41 Update k8s_secret.go
5411b9c change annotations to certimage.
46dccb1 fix typo, get annotations from cert.

📊 Changes

1 file changed (+48 additions, -15 deletions)

View changed files

📝 internal/deployer/k8s_secret.go (+48 -15)

📄 Description

支持当secret不存在的时候可以创建，添加annotations，简化客户端连接。添加了secret type。

解决了#226 。

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/certimate-go/certimate/pull/251 **Author:** [@aazf](https://github.com/aazf) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@usual2970](https://github.com/usual2970) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`528a3d9`](https://github.com/certimate-go/certimate/commit/528a3d9da8b448a6640149c2b71e452929fe909c) support create secret, add cert annotations. - [`9f6ea41`](https://github.com/certimate-go/certimate/commit/9f6ea410af085fef9a89d5515117deef0c47a69a) Update k8s_secret.go - [`5411b9c`](https://github.com/certimate-go/certimate/commit/5411b9cb92e571c4828d93c0e6d6fd3ec661ad83) change annotations to certimage. - [`46dccb1`](https://github.com/certimate-go/certimate/commit/46dccb176ec27d258e4dcec6afba1e3dbd61d4be) fix typo, get annotations from cert. ### 📊 Changes **1 file changed** (+48 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `internal/deployer/k8s_secret.go` (+48 -15) </details> ### 📄 Description 支持当secret不存在的时候可以创建，添加annotations，简化客户端连接。添加了secret type。解决了#226 。 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>