[PR #1074] [CLOSED] fix: disbale cn in csr for specific profile #1131

Closed
opened 2026-03-03 01:07:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/certimate-go/certimate/pull/1074
Author: @ZeroClover
Created: 12/1/2025
Status: Closed

Base: mainHead: fix/disable-cn


📝 Commits (1)

  • 6913039 fix: disbale cn in csr for specific profile

📊 Changes

2 files changed (+8 additions, -0 deletions)

View changed files

📝 cmd/intercmd.go (+4 -0)
📝 internal/workflow/engine/executor_bizapply.go (+4 -0)

📄 Description

fix https://github.com/certimate-go/certimate/issues/1072

Pass flag to lego to disable CN in CSR when using tlsserver or shortlived configuration

According to Let's Encrypt documentation, certificates issued when using these two Profiles do not contain CN, so removing CN from the CSR is also reasonable

Also avoid including IP addresses in CSR CN when issuing IP certificates


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/certimate-go/certimate/pull/1074 **Author:** [@ZeroClover](https://github.com/ZeroClover) **Created:** 12/1/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/disable-cn` --- ### 📝 Commits (1) - [`6913039`](https://github.com/certimate-go/certimate/commit/691303910fdc91fac55f4f7890877e5fa35982bc) fix: disbale cn in csr for specific profile ### 📊 Changes **2 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/intercmd.go` (+4 -0) 📝 `internal/workflow/engine/executor_bizapply.go` (+4 -0) </details> ### 📄 Description fix https://github.com/certimate-go/certimate/issues/1072 Pass flag to lego to disable CN in CSR when using `tlsserver` or `shortlived` configuration According to Let's Encrypt documentation, certificates issued when using these two Profiles do not contain CN, so removing CN from the CSR is also reasonable Also avoid including IP addresses in CSR CN when issuing IP certificates --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 01:07:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/certimate#1131
No description provided.