[PR #1048] [MERGED] bugfix #1122

New issue

Closed

opened 2026-03-03 01:07:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:07:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/certimate-go/certimate/pull/1048
Author: @Qmli04
Created: 11/20/2025
Status: ✅ Merged
Merged: 11/20/2025
Merged by: @fudiwei

Base: main ← Head: QmLi

📝 Commits (2)

75a8870 fix: upload the certificate to aliyun slb repeatedly
d1ed325 fix: init tencent waf deployer add region param

📊 Changes

2 files changed (+7 additions, -3 deletions)

View changed files

📝 internal/certdeploy/deployers/sp_tencentcloud_waf.go (+1 -0)
📝 pkg/core/certmgr/providers/aliyun-slb/aliyun_slb.go (+6 -3)

📄 Description

该 PR 包含以下内容变更：

修复阿里云clb证书重复上传问题

阿里云 slb.DescribeServerCertificates api 返回的 Fingerprint字段是sha1的。但在certimate的aliyun slb upload中，是通过sha2计算出Fingerprint，这会导致指纹匹配失败，证书重复上传。

虽然许多组织和浏览器已经弃用 sha1，但为了解决这个问题，该pr在上传证书到aliyun slb中，同时支持了sha1和sha256校验

修复初始化腾讯云waf deployer时未传region参数的问题

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/certimate-go/certimate/pull/1048 **Author:** [@Qmli04](https://github.com/Qmli04) **Created:** 11/20/2025 **Status:** ✅ Merged **Merged:** 11/20/2025 **Merged by:** [@fudiwei](https://github.com/fudiwei) **Base:** `main` ← **Head:** `QmLi` --- ### 📝 Commits (2) - [`75a8870`](https://github.com/certimate-go/certimate/commit/75a88703f7fb71cab5168f06d87ea88badb8d56e) fix: upload the certificate to aliyun slb repeatedly - [`d1ed325`](https://github.com/certimate-go/certimate/commit/d1ed3255797ff35404334a859370d60f557a14aa) fix: init tencent waf deployer add region param ### 📊 Changes **2 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/certdeploy/deployers/sp_tencentcloud_waf.go` (+1 -0) 📝 `pkg/core/certmgr/providers/aliyun-slb/aliyun_slb.go` (+6 -3) </details> ### 📄 Description 该 PR 包含以下内容变更： - 修复阿里云clb证书重复上传问题阿里云 slb.DescribeServerCertificates api 返回的 Fingerprint字段是sha1的。但在certimate的aliyun slb upload中，是通过sha2计算出Fingerprint，这会导致指纹匹配失败，证书重复上传。虽然许多组织和浏览器已经弃用 sha1，但为了解决这个问题，该pr在上传证书到aliyun slb中，同时支持了sha1和sha256校验 - 修复初始化腾讯云waf deployer时未传region参数的问题 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>