[PR #693] [MERGED] refactor #1014

New issue

Closed

opened 2026-03-03 01:07:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:07:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/certimate-go/certimate/pull/693
Author: @fudiwei
Created: 5/16/2025
Status: ✅ Merged
Merged: 5/16/2025
Merged by: @fudiwei

Base: main ← Head: main

📝 Commits (3)

dd2087b refactor: clean code
b15bf8e refactor: clean code
ef0f0f6 refactor: remove nikoksr/notify deps

📊 Changes

54 files changed (+370 additions, -417 deletions)

View changed files

📝 go.mod (+2 -8)
📝 go.sum (+2 -10)
📝 internal/domain/access.go (+1 -1)
📝 internal/domain/provider.go (+2 -2)
📝 internal/notify/providers.go (+10 -10)
📝 internal/notify/providers_deprecated.go (+8 -8)
📝 internal/pkg/core/deployer/providers/webhook/webhook.go (+1 -3)
📝 internal/pkg/core/notifier/providers/bark/bark.go (+27 -13)
📝 internal/pkg/core/notifier/providers/dingtalkbot/dingtalkbot.go (+11 -10)
📝 internal/pkg/core/notifier/providers/dingtalkbot/dingtalkbot_test.go (+12 -11)
📝 internal/pkg/core/notifier/providers/gotify/gotify.go (+21 -42)
📝 internal/pkg/core/notifier/providers/gotify/gotify_test.go (+3 -3)
📝 internal/pkg/core/notifier/providers/larkbot/larkbot.go (+13 -6)
📝 internal/pkg/core/notifier/providers/larkbot/larkbot_test.go (+5 -5)
📝 internal/pkg/core/notifier/providers/mattermost/mattermost.go (+38 -31)
📝 internal/pkg/core/notifier/providers/pushover/pushover.go (+17 -43)
📝 internal/pkg/core/notifier/providers/pushplus/pushplus.go (+22 -46)
📝 internal/pkg/core/notifier/providers/serverchan/serverchan.go (+22 -23)
📝 internal/pkg/core/notifier/providers/serverchan/serverchan_test.go (+1 -1)
📝 internal/pkg/core/notifier/providers/telegrambot/telegrambot.go (+23 -15)

...and 34 more files

📄 Description

该 PR 包含以下内容变更：

refactor: 继 #691 后，进一步优化第三方 SDK 实现，移除 nikoksr/notify 依赖

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/certimate-go/certimate/pull/693 **Author:** [@fudiwei](https://github.com/fudiwei) **Created:** 5/16/2025 **Status:** ✅ Merged **Merged:** 5/16/2025 **Merged by:** [@fudiwei](https://github.com/fudiwei) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`dd2087b`](https://github.com/certimate-go/certimate/commit/dd2087b10119d58c459cb4a16e45f72d13d05dd3) refactor: clean code - [`b15bf8e`](https://github.com/certimate-go/certimate/commit/b15bf8ef9817b216d415eebd70d804ec7ea6e0e1) refactor: clean code - [`ef0f0f6`](https://github.com/certimate-go/certimate/commit/ef0f0f6b43f648be8318457733731338a976d9d1) refactor: remove nikoksr/notify deps ### 📊 Changes **54 files changed** (+370 additions, -417 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+2 -8) 📝 `go.sum` (+2 -10) 📝 `internal/domain/access.go` (+1 -1) 📝 `internal/domain/provider.go` (+2 -2) 📝 `internal/notify/providers.go` (+10 -10) 📝 `internal/notify/providers_deprecated.go` (+8 -8) 📝 `internal/pkg/core/deployer/providers/webhook/webhook.go` (+1 -3) 📝 `internal/pkg/core/notifier/providers/bark/bark.go` (+27 -13) 📝 `internal/pkg/core/notifier/providers/dingtalkbot/dingtalkbot.go` (+11 -10) 📝 `internal/pkg/core/notifier/providers/dingtalkbot/dingtalkbot_test.go` (+12 -11) 📝 `internal/pkg/core/notifier/providers/gotify/gotify.go` (+21 -42) 📝 `internal/pkg/core/notifier/providers/gotify/gotify_test.go` (+3 -3) 📝 `internal/pkg/core/notifier/providers/larkbot/larkbot.go` (+13 -6) 📝 `internal/pkg/core/notifier/providers/larkbot/larkbot_test.go` (+5 -5) 📝 `internal/pkg/core/notifier/providers/mattermost/mattermost.go` (+38 -31) 📝 `internal/pkg/core/notifier/providers/pushover/pushover.go` (+17 -43) 📝 `internal/pkg/core/notifier/providers/pushplus/pushplus.go` (+22 -46) 📝 `internal/pkg/core/notifier/providers/serverchan/serverchan.go` (+22 -23) 📝 `internal/pkg/core/notifier/providers/serverchan/serverchan_test.go` (+1 -1) 📝 `internal/pkg/core/notifier/providers/telegrambot/telegrambot.go` (+23 -15) _...and 34 more files_ </details> ### 📄 Description 该 PR 包含以下内容变更： - **refactor**: 继 #691 后，进一步优化第三方 SDK 实现，移除 nikoksr/notify 依赖 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>