[PR #19] [MERGED] bugfix + cleanup #53

Closed
opened 2026-03-02 04:09:05 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/gen2brain/cam2ip/pull/19
Author: @RandomErrorMessage
Created: 9/27/2019
Status: Merged
Merged: 9/29/2019
Merged by: @gen2brain

Base: masterHead: master


📝 Commits (5)

  • ff09bbe bugfix: missing string addition in javascript
  • 6b28dfe removed unused function parameter
  • 5b7d51a updated go modules, removed goost base64 dependency
  • f1df08a encoding/base64 is stdlib, re-ordered
  • 01b9c56 re-added goost after fixing upstream amd64 build bug

📊 Changes

4 files changed (+41 additions, -25 deletions)

View changed files

📝 go.mod (+10 -7)
📝 go.sum (+27 -14)
📝 handlers/html.go (+3 -3)
📝 server/server.go (+1 -1)

📄 Description

When I updated the modules I had issues with goost, so I replaced it with stdlib base64. I couldn't find much info on goost so I assume it's a drop in replacement.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/gen2brain/cam2ip/pull/19 **Author:** [@RandomErrorMessage](https://github.com/RandomErrorMessage) **Created:** 9/27/2019 **Status:** ✅ Merged **Merged:** 9/29/2019 **Merged by:** [@gen2brain](https://github.com/gen2brain) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`ff09bbe`](https://github.com/gen2brain/cam2ip/commit/ff09bbeff42d466e8f3c7787005d1b0eb43e5d5b) bugfix: missing string addition in javascript - [`6b28dfe`](https://github.com/gen2brain/cam2ip/commit/6b28dfec25bab6d4bdd06364b77b1d2bc8baaccc) removed unused function parameter - [`5b7d51a`](https://github.com/gen2brain/cam2ip/commit/5b7d51a9ac42a4c75a1562963b928d954cd9743e) updated go modules, removed goost base64 dependency - [`f1df08a`](https://github.com/gen2brain/cam2ip/commit/f1df08acc728099e3e479068c2b1d2fc6864fc24) encoding/base64 is stdlib, re-ordered - [`01b9c56`](https://github.com/gen2brain/cam2ip/commit/01b9c564acfbd7b2423b8907c0fe066eb52705ee) re-added goost after fixing upstream amd64 build bug ### 📊 Changes **4 files changed** (+41 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+10 -7) 📝 `go.sum` (+27 -14) 📝 `handlers/html.go` (+3 -3) 📝 `server/server.go` (+1 -1) </details> ### 📄 Description When I updated the modules I had issues with goost, so I replaced it with stdlib base64. I couldn't find much info on goost so I assume it's a drop in replacement. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 04:09:05 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cam2ip#53
No description provided.