[GH-ISSUE #290] Importing config file duplicates additional files #255

Closed
opened 2026-02-26 12:20:58 +03:00 by kerem · 4 comments
Owner

Originally created by @TheGeeKing on GitHub (Jul 26, 2022).
Original GitHub issue: https://github.com/brentvollebregt/auto-py-to-exe/issues/290

Originally assigned to: @brentvollebregt on GitHub.

Quick Checks For You

  • I have read/searched in the help post
  • I have searched other issues looking for an issue similar to mine
  • I have made sure my applicaiton/script runs before trying to package

Describe the bug
Importing a configuration file doesn't reset the additional files fields and add/duplicate files.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings
  2. Import a configuration file with additional file in it
  3. If you had previous files in the additional files section their will still be there
  4. If you import once again the config file, additional files will be duplicated

Expected behavior
The additional files fields should be cleared as stated when importing the config file: Override current configuration? All previously inserted values will be erased.

Screenshots
State 0:
image

After imported a config file:
image

If you import once again a config file:
image

Your Environment:

  • Python version (python --version): 3.10.4
  • auto-py-to-exe version (pip show auto-py-to-exe): 2.21.0
  • PyInstaller version (pip show pyinstaller): 5.1
  • Eel version (pip show eel): 0.14.0
Originally created by @TheGeeKing on GitHub (Jul 26, 2022). Original GitHub issue: https://github.com/brentvollebregt/auto-py-to-exe/issues/290 Originally assigned to: @brentvollebregt on GitHub. **Quick Checks For You** - [x] I have read/searched in the [help post](https://nitratine.net/blog/post/issues-when-using-auto-py-to-exe) - [x] I have [searched other issues](https://github.com/brentvollebregt/auto-py-to-exe/issues?q=is%3Aissue+) looking for an issue similar to mine - [x] I have made sure my applicaiton/script runs before trying to package **Describe the bug** Importing a configuration file doesn't reset the additional files fields and add/duplicate files. **To Reproduce** Steps to reproduce the behavior: 1. Go to `Settings` 2. Import a configuration file with additional file in it 3. If you had previous files in the additional files section their will still be there 4. If you import once again the config file, additional files will be duplicated **Expected behavior** The additional files fields should be cleared as stated when importing the config file: `Override current configuration? All previously inserted values will be erased.` **Screenshots** State 0: ![image](https://user-images.githubusercontent.com/58857539/180999632-c1cd49f6-c4b4-4771-8c05-c1994390dd12.png) After imported a config file: ![image](https://user-images.githubusercontent.com/58857539/180999741-4d457405-f617-4b40-86bc-c46c27493fe3.png) If you import once again a config file: ![image](https://user-images.githubusercontent.com/58857539/180999878-473a62df-3c51-4595-b0d6-6a3461b504ec.png) **Your Environment:** - Python version (`python --version`): 3.10.4 - auto-py-to-exe version (`pip show auto-py-to-exe`): 2.21.0 - PyInstaller version (`pip show pyinstaller`): 5.1 - Eel version (`pip show eel`): 0.14.0
kerem 2026-02-26 12:20:58 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@brentvollebregt commented on GitHub (Jul 27, 2022):

Ah yep, I see the issue here. There are also many other places like "Advanced -> What to bundle, where to search" that will have a similar issue.

I feel like the best method would be to re-initialise the UI to clear everything before applying the configuration.

<!-- gh-comment-id:1196306593 --> @brentvollebregt commented on GitHub (Jul 27, 2022): Ah yep, I see the issue here. There are also many other places like "Advanced -> What to bundle, where to search" that will have a similar issue. I feel like the best method would be to re-initialise the UI to clear everything before applying the configuration.
Author
Owner

@brentvollebregt commented on GitHub (Aug 3, 2022):

@TheGeeKing sorry for the delay on this - I have a proposed change in bugfix/290-import-config-not-clearing-values.

A couple of things worth noting:

  • This will now reload the whole window when importing the config - this is done to make sure that all fields are reset and validated before adding the data
  • I was originally going with a method to clear each input and then validate them before replacing the config but this got a bit messy
<!-- gh-comment-id:1203785620 --> @brentvollebregt commented on GitHub (Aug 3, 2022): @TheGeeKing sorry for the delay on this - I have a proposed change in [bugfix/290-import-config-not-clearing-values](https://github.com/brentvollebregt/auto-py-to-exe/tree/bugfix/290-import-config-not-clearing-values). A couple of things worth noting: - This will now reload the whole window when importing the config - this is done to make sure that all fields are reset and validated before adding the data - I was originally going with a method to clear each input and then validate them before replacing the config but this got a bit messy
Author
Owner

@TheGeeKing commented on GitHub (Aug 3, 2022):

Hi @brentvollebregt,

No problem for the delay.

Yeah, I think this solution is perfect, it simply reset the window by reloading it and doesn't need extra step to validate them. It requires less code and makes it error proof for future updates.

Thanks for this great tool!

<!-- gh-comment-id:1203809291 --> @TheGeeKing commented on GitHub (Aug 3, 2022): Hi @brentvollebregt, No problem for the delay. Yeah, I think this solution is perfect, it simply reset the window by reloading it and doesn't need extra step to validate them. It requires less code and makes it error proof for future updates. Thanks for this great tool!
Author
Owner

@brentvollebregt commented on GitHub (Aug 3, 2022):

This has just been merged into master and has been released as part of auto-py-to-exe v2.21.1.

Thank you very much for the clear bug report, it really makes a difference!

<!-- gh-comment-id:1203826585 --> @brentvollebregt commented on GitHub (Aug 3, 2022): This has just been merged into master and has been released as part of auto-py-to-exe v2.21.1. Thank you very much for the clear bug report, it really makes a difference!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/auto-py-to-exe#255
No description provided.