[GH-ISSUE #98] Swift gRPC plugin for protoc #59

Closed
opened 2026-03-03 19:11:25 +03:00 by kerem · 2 comments
Owner

Originally created by @r-plus on GitHub (Mar 31, 2022).
Original GitHub issue: https://github.com/ProxymanApp/atlantis/issues/98

We should write all of the YourClientInterceptorFactoryProtocol protocol defined methods for gRPC like this.

public class AtlantisInterceptorFactory: MyClientInterceptorFactoryProtocol {
    public func makeAInterceptors() -> [ClientInterceptor<ARequest, AResponse>] {
        [AtlantisInterceptor()]
    }
    public func makeBInterceptors() -> [ClientInterceptor<BRequest, BResponse>] {
        [AtlantisInterceptor()]
    }
    public func makeCInterceptors() -> [ClientInterceptor<CRequest, CResponse>] {
        [AtlantisInterceptor()]
    }
    ...

It would be nice if it could be generated automatically by grpc plugin including AtlantisInterceptor implementation that wrote on README to reduce the hassle like swift-grpc plugin.

Originally created by @r-plus on GitHub (Mar 31, 2022). Original GitHub issue: https://github.com/ProxymanApp/atlantis/issues/98 We should write all of the `YourClientInterceptorFactoryProtocol` protocol defined methods for gRPC like this. ``` public class AtlantisInterceptorFactory: MyClientInterceptorFactoryProtocol { public func makeAInterceptors() -> [ClientInterceptor<ARequest, AResponse>] { [AtlantisInterceptor()] } public func makeBInterceptors() -> [ClientInterceptor<BRequest, BResponse>] { [AtlantisInterceptor()] } public func makeCInterceptors() -> [ClientInterceptor<CRequest, CResponse>] { [AtlantisInterceptor()] } ... ``` It would be nice if it could be generated automatically by grpc plugin including AtlantisInterceptor implementation that wrote on README to reduce the hassle like [swift-grpc plugin](https://github.com/grpc/grpc-swift/tree/main/Sources/protoc-gen-grpc-swift).
kerem closed this issue 2026-03-03 19:11:25 +03:00
Author
Owner

@NghiaTranUIT commented on GitHub (Apr 10, 2022):

Thanks but I'm not sure how to tackle this.

<!-- gh-comment-id:1094221471 --> @NghiaTranUIT commented on GitHub (Apr 10, 2022): Thanks but I'm not sure how to tackle this.
Author
Owner

@r-plus commented on GitHub (Aug 22, 2022):

In past, I thought creating protoc plugin for this purpose is good idea.
But now I'm thinking creating plugin plan that generated code will completely depend on grpc-swift's protoc-gen-grpc-swift is not good for Atlantis.

Thanks.
I'll open issue when I got more good robust idea.

<!-- gh-comment-id:1222625701 --> @r-plus commented on GitHub (Aug 22, 2022): In past, I thought creating protoc plugin for this purpose is good idea. But now I'm thinking creating plugin plan that generated code will completely depend on grpc-swift's protoc-gen-grpc-swift is not good for Atlantis. Thanks. I'll open issue when I got more good robust idea.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/atlantis#59
No description provided.