mirror of
https://github.com/ProxymanApp/atlantis.git
synced 2026-04-26 16:36:03 +03:00
[GH-ISSUE #57] app crash if we download big (>300 MB) file #38
Labels
No labels
Done
Done
Windows
bug
bug
bug
enhancement
enhancement
enhancement
good first issue
hacktoberfest
pull-request
wontfix
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/atlantis#38
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jsyrtsov on GitHub (Feb 10, 2021).
Original GitHub issue: https://github.com/ProxymanApp/atlantis/issues/57
Originally assigned to: @NghiaTranUIT on GitHub.
please add any comments here if you need more information about this issue
@NghiaTranUIT commented on GitHub (Feb 10, 2021):
Sorry to hear that but I'm not sure why NetServiceTransort is not capable of sending your big file.
I suppose that I should have a save check to skip big files, such as over 100Mb to prevent the app crashes 👍
@jsyrtsov commented on GitHub (Feb 10, 2021):
@NghiaTranUIT thank you for fast answer!
@NghiaTranUIT commented on GitHub (Feb 10, 2021):
@jsyrtsov if you don't mind, please use this pod:
and share with me whether or not it fixes the crash 😄
Thank you in advance 👍
@jsyrtsov commented on GitHub (Feb 10, 2021):
@NghiaTranUIT give me few minutes
@jsyrtsov commented on GitHub (Feb 10, 2021):
@NghiaTranUIT I'm sorry but right now I can't test it, server with large files is not working now. But I'd like to set 50Mb limit instead of 100Mb.
@jsyrtsov commented on GitHub (Feb 10, 2021):
@NghiaTranUIT
I've tested with 100 Mb limit, got crash. 50 Mb limit crashed too. 20 Mb limit crashed too, I have assumption that buffer is not clearing, what do you think about it ?
@NghiaTranUIT commented on GitHub (Feb 10, 2021):
Thanks for getting back. Let me check the root of the problem 👍
@NghiaTranUIT commented on GitHub (Feb 10, 2021):
I'm not sure but I could transfer 50Mb by Atlantis to Proxyman macOS.
However, it crashes when I tried a file 150Mb 😿 Google show that there is no memory left, so it crashes the app.
@jsyrtsov:
@jsyrtsov commented on GitHub (Feb 10, 2021):
@NghiaTranUIT
I'm running on iPhone 7 iOS 13.7 and iOS 14.4 (both of these devices are crashing. I did't try to repeat crash on any simulator, should I?
I'm downloading two big files at the same time (~30MB + ~200MB + ~300MB. it is catalog DataBases) and Atlantis is trying to send it to Proxyman almost simultaneously and got crash on second file.
I can try to find some links with big files if you need it.
Also I can just exclude domain with catalogs from Transporting to Atlantis.
Thnx in advance.
@NghiaTranUIT commented on GitHub (Feb 10, 2021):
Yes, please try on the Simulator too, since there is plenty of RAM. Try on 20Mb and 100Mb.
Good idea. I might support the Exclusive List 😄
@jsyrtsov commented on GitHub (Feb 10, 2021):
Okay, I'll try on simulator without limit and with different limits
@NghiaTranUIT commented on GitHub (Feb 10, 2021):
Look like I found the problem @jsyrtsov The bug is from JSONEncoder, not the URLStreamTask.
Since the file size is large, it might not be able to represent in the JSON Format. I'm looking for a solution to exclude in this case
@jsyrtsov commented on GitHub (Feb 10, 2021):
oh, good news!
@NghiaTranUIT commented on GitHub (Feb 10, 2021):
@jsyrtsov let check the latest commit from
bug/crash-big-filesbranch 👍I decide to skip the large body if it exceeds the threshold (100Mb)
@jsyrtsov commented on GitHub (Feb 10, 2021):
I've got crash with 100MB limit and with 50MB limit. With 25MB limit everything is OK)
@jsyrtsov commented on GitHub (Feb 10, 2021):
I've tested on simulator and didn't get any crashes. But on iPhone 7 I don't get crash only if I set 25MB limit.
@NghiaTranUIT commented on GitHub (Feb 11, 2021):
Thanks. I would like to limit the big file size to 50Mb. iPhone 7 lacks available RAM, so it might be crashed