mirror of
https://github.com/ProxymanApp/atlantis.git
synced 2026-04-26 08:26:04 +03:00
[GH-ISSUE #47] Assertion Failure when using file URLs #36
Labels
No labels
Done
Done
Windows
bug
bug
bug
enhancement
enhancement
enhancement
good first issue
hacktoberfest
pull-request
wontfix
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/atlantis#36
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kenjitayama on GitHub (Dec 23, 2020).
Original GitHub issue: https://github.com/ProxymanApp/atlantis/issues/47
Originally assigned to: @NghiaTranUIT on GitHub.
I get this assertion failure when using file URLs.
It can be reproduced with this code in an iOS app.
In our app, many resources are retrieved from a web server, while some are bundled in the app.
For a specific kind of resource, we want to use the same implementation for web and bundled file, which uses URLSessionDownloadTask.
It would be helpful if this assertionFailure is removed.
@NghiaTranUIT commented on GitHub (Dec 23, 2020):
Thanks for opening this issue. I'm looking at it and remove it as possible 👍
@NghiaTranUIT commented on GitHub (Dec 23, 2020):
Hey @kenjitayama,
Can you share with us:
I tried to reproduce but it's working fine (Proxyman 2.15.1, iOS 14 and Atlantis 1.4.3)
Both URLSessionDownloadTasks are still working
@NghiaTranUIT commented on GitHub (Dec 23, 2020):
One more thing, when the
assertionFailureoccurs, can you print out the type of response variable?The easier way is that you set the breakpoint at
Atlantis/Packages.swift, line 209and typepo responseto see the type and content.@kenjitayama commented on GitHub (Dec 23, 2020):
@NghiaTranUIT Thanks for checking the issue!!
I am using iOS 14.0 and Atlantis 1.4.3.
Did this when assertionFailure occured (I changed the app name in the URL):
You need to use a
file://URL to reproduce.@NghiaTranUIT commented on GitHub (Dec 23, 2020):
Thanks. I'm able to reproduce this bug. Fixing now 👍
@NghiaTranUIT commented on GitHub (Dec 23, 2020):
@kenjitayama please check out the 1.5.0 version, which I've released (https://github.com/ProxymanApp/atlantis/releases/tag/1.5.0)
It fixes your problem 👍 Thank you and Merry Christmas 🎉
@kenjitayama commented on GitHub (Dec 23, 2020):
@NghiaTranUIT Thanks for the quick fix!
Confirmed the issue is resolved in our app.
It's nice that we could see
file://URLs in Proxyman too 👍Merry Christmas 🎄
@NghiaTranUIT commented on GitHub (Dec 23, 2020):
Glad to know it works 🎉