mirror of
https://github.com/ProxymanApp/atlantis.git
synced 2026-04-26 08:26:04 +03:00
[GH-ISSUE #24] Support Carthage #22
Labels
No labels
Done
Done
Windows
bug
bug
bug
enhancement
enhancement
enhancement
good first issue
hacktoberfest
pull-request
wontfix
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/atlantis#22
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @NghiaTranUIT on GitHub (Nov 1, 2020).
Original GitHub issue: https://github.com/ProxymanApp/atlantis/issues/24
Originally assigned to: @NghiaTranUIT on GitHub.
Description
As we've already supported Cocoapod and Swift Package Manager, we should also support Carthage 👍
@pokryfka commented on GitHub (Nov 8, 2021):
@NghiaTranUIT Not sure what is the status of that since README does mention Carthage https://github.com/ProxymanApp/atlantis#carthage
Regardless, it fails for me, please see details below.
Steps:
echo 'github "ProxymanApp/atlantis"' > Cartfilecarthage update --use-xcframeworks --platform iOSResult:
@pokryfka commented on GitHub (Jan 31, 2022):
👋
@saim80 commented on GitHub (Jun 14, 2022):
I found this issue, too. Please support Carthage. I don't want to increase build time by adding more SPM packages.
@NghiaTranUIT commented on GitHub (Jun 15, 2022):
Hey @saim80 @pokryfka since Atlantis is a pure SPM (no
xcprojectfile), so Atlantis doesn't work well.@saim80 please try this branch instead
I generated the
xcprojectfile and it should work 👍@NghiaTranUIT commented on GitHub (Jun 15, 2022):
It's quite tricky to set up Carthage work with xcframework, so I still highly suggest using the Swift Package Manager because it's straightforward to integrate Atlantis into your project.
@stevelandeyasana commented on GitHub (Jul 15, 2022):
This is marked 'done', and the README has Carthage instructions, but I still get this error message. Here's my Cartfile line:
Your branch
feat/add-carthageworks. Can it be merged?@NghiaTranUIT commented on GitHub (Jul 16, 2022):
@stevelandeyasana It's merged and released on Atlantis 1.18.1 👍 : https://github.com/ProxymanApp/atlantis/releases/tag/1.18.1
@stevelandeyasana commented on GitHub (Jul 19, 2022):
Thank you so much, works great!