[PR #188] [MERGED] Skip .icns assets when running macOS Catalyst #187

New issue

Closed

opened 2026-03-03 19:12:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:12:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ProxymanApp/atlantis/pull/188
Author: @VIadislavJevremovic
Created: 2/23/2026
Status: ✅ Merged
Merged: 2/23/2026
Merged by: @NghiaTranUIT

Base: main ← Head: bugfix/macos-icon

📝 Commits (1)

347427c Skip .icns assets on Catalyst

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 Sources/Packages.swift (+3 -0)

📄 Description

Hello, we've encountered a crash during icon loading when running on a macOS Catalyst target with Proxyman active. I've found that .icon assets for Liquid Glass get converted to .icns in bundle on Catalyst. But that can only be loaded with NSImage, not Image. So I added an early-exit guard in the macCatalyst branch of the app icon resolution logic in Packages.swift.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ProxymanApp/atlantis/pull/188 **Author:** [@VIadislavJevremovic](https://github.com/VIadislavJevremovic) **Created:** 2/23/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@NghiaTranUIT](https://github.com/NghiaTranUIT) **Base:** `main` ← **Head:** `bugfix/macos-icon` --- ### 📝 Commits (1) - [`347427c`](https://github.com/ProxymanApp/atlantis/commit/347427cb8716975dba6615410e877253086d78ea) Skip .icns assets on Catalyst ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Packages.swift` (+3 -0) </details> ### 📄 Description Hello, we've encountered a crash during icon loading when running on a macOS Catalyst target with Proxyman active. I've found that .icon assets for Liquid Glass get converted to .icns in bundle on Catalyst. But that can only be loaded with NSImage, not Image. So I added an early-exit guard in the macCatalyst branch of the app icon resolution logic in Packages.swift. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>