[PR #172] [MERGED] Make sure all accesses to `URLSessionTask.currentRequest` are crash safe #175

New issue

Closed

opened 2026-03-03 19:12:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:12:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ProxymanApp/atlantis/pull/172
Author: @arrizer
Created: 7/15/2025
Status: ✅ Merged
Merged: 7/16/2025
Merged by: @NghiaTranUIT

Base: main ← Head: fix/crash-avaggregateassetdownloadtask

📝 Commits (1)

72a36ae Make sure all accesses to URLSessionTask.currentRequest are crash safe

📊 Changes

3 files changed (+23 additions, -16 deletions)

View changed files

📝 Sources/Atlantis.swift (+1 -1)
📝 Sources/Packages.swift (+2 -15)
➕ Sources/URLSessionTask+CurrentRequest.swift (+20 -0)

📄 Description

This was already fixed in https://github.com/ProxymanApp/atlantis/pull/151 but unfortunately reintroduced by another call to .currentRequest in github.com/ProxymanApp/atlantis@b9542919ae

This PR adds a new extension to move the access check to a shared location

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ProxymanApp/atlantis/pull/172 **Author:** [@arrizer](https://github.com/arrizer) **Created:** 7/15/2025 **Status:** ✅ Merged **Merged:** 7/16/2025 **Merged by:** [@NghiaTranUIT](https://github.com/NghiaTranUIT) **Base:** `main` ← **Head:** `fix/crash-avaggregateassetdownloadtask` --- ### 📝 Commits (1) - [`72a36ae`](https://github.com/ProxymanApp/atlantis/commit/72a36aeda779586d3ce856ec3f6884c141e0d4f3) Make sure all accesses to `URLSessionTask.currentRequest` are crash safe ### 📊 Changes **3 files changed** (+23 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Atlantis.swift` (+1 -1) 📝 `Sources/Packages.swift` (+2 -15) ➕ `Sources/URLSessionTask+CurrentRequest.swift` (+20 -0) </details> ### 📄 Description This was already fixed in https://github.com/ProxymanApp/atlantis/pull/151 but unfortunately reintroduced by another call to `.currentRequest` in https://github.com/ProxymanApp/atlantis/commit/b9542919ae59dbecff5374c52c40cb62d2f57164 This PR adds a new extension to move the access check to a shared location --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>