[PR #157] [MERGED] hotfix: Fix missing requests when ignore urlprotocol #166

New issue

Closed

opened 2026-03-03 19:12:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:12:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ProxymanApp/atlantis/pull/157
Author: @HoaPham98
Created: 12/13/2024
Status: ✅ Merged
Merged: 3/23/2025
Merged by: @NghiaTranUIT

Base: main ← Head: hotfix/missing-requests-when-ignore-urlprotocol

📝 Commits (1)

9eaba2e hotfix: Fix missing requests when ignore urlprotocol

📊 Changes

1 file changed (+11 additions, -3 deletions)

View changed files

📝 Sources/Atlantis.swift (+11 -3)

📄 Description

In the previous pull request https://github.com/ProxymanApp/atlantis/pull/155, I added a fix for the duplicate request issue caused by the app using URLProtocol, but there was one issue: I checked all the requests with the protocol that needed to be ignored, but I forgot that only those URLSessions with URLProtocol are processed, resulting in some URLDataTasks using other URLSessions being overlooked

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ProxymanApp/atlantis/pull/157 **Author:** [@HoaPham98](https://github.com/HoaPham98) **Created:** 12/13/2024 **Status:** ✅ Merged **Merged:** 3/23/2025 **Merged by:** [@NghiaTranUIT](https://github.com/NghiaTranUIT) **Base:** `main` ← **Head:** `hotfix/missing-requests-when-ignore-urlprotocol` --- ### 📝 Commits (1) - [`9eaba2e`](https://github.com/ProxymanApp/atlantis/commit/9eaba2e3a0b3a13c8dfcb15f570b17f4bebf9f8e) hotfix: Fix missing requests when ignore urlprotocol ### 📊 Changes **1 file changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Atlantis.swift` (+11 -3) </details> ### 📄 Description In the previous pull request https://github.com/ProxymanApp/atlantis/pull/155, I added a fix for the duplicate request issue caused by the app using URLProtocol, but there was one issue: I checked all the requests with the protocol that needed to be ignored, but I forgot that only those URLSessions with URLProtocol are processed, resulting in some URLDataTasks using other URLSessions being overlooked --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>