[PR #27] [MERGED] Fix CFBundleVersion in framework bundle #110

New issue

Closed

opened 2026-03-03 19:11:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:11:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ProxymanApp/atlantis/pull/27
Author: @florianbuerger
Created: 11/3/2020
Status: ✅ Merged
Merged: 11/3/2020
Merged by: @NghiaTranUIT

Base: main ← Head: main

📝 Commits (2)

3b5935a Bump marketing version to 1.1.0
0586847 Set CURRENT_PROJECT_VERSION to 1

📊 Changes

3 files changed (+536 additions, -699 deletions)

View changed files

📝 Atlantis.xcodeproj/AtlantisTests_Info.plist (+1 -1)
📝 Atlantis.xcodeproj/Atlantis_Info.plist (+1 -1)
📝 Atlantis.xcodeproj/project.pbxproj (+534 -697)

📄 Description

Hey,

Thank you so so much for Atlantis! I've been a big fan of Proxyman and I have been using since the beginning. I always wished for an easier way to capture traffic from test devices. I also often forgot to revert the proxy settings on the device and then wonder why it isn't connected anymore 🙄

Anyway, I tried to publish an app to TestFlight but the validation doesn't pass. The framework was integrated by Carthage.

ERROR ITMS-90056: "This bundle Payload/Flighty Int.app/Frameworks/Atlantis.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion. Please find more information about CFBundleVersion at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion"

The framework bundle needs to include a value for CFBundleVersion. It was set to CURRENT_PROJECT_VERSION but that variable wasn't set in the project file. I set it to 1 for now, just to pass the App Store Connect validation.

I also bumped the CFBundleShortVersion to 1.1.0 even though I don't think it will be used anywhere.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ProxymanApp/atlantis/pull/27 **Author:** [@florianbuerger](https://github.com/florianbuerger) **Created:** 11/3/2020 **Status:** ✅ Merged **Merged:** 11/3/2020 **Merged by:** [@NghiaTranUIT](https://github.com/NghiaTranUIT) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`3b5935a`](https://github.com/ProxymanApp/atlantis/commit/3b5935ada4d0b5733a5d5d0cb587ff4cbf3a5d15) Bump marketing version to 1.1.0 - [`0586847`](https://github.com/ProxymanApp/atlantis/commit/0586847d619cb9af192fb2dc1773275da4932c56) Set CURRENT_PROJECT_VERSION to 1 ### 📊 Changes **3 files changed** (+536 additions, -699 deletions) <details> <summary>View changed files</summary> 📝 `Atlantis.xcodeproj/AtlantisTests_Info.plist` (+1 -1) 📝 `Atlantis.xcodeproj/Atlantis_Info.plist` (+1 -1) 📝 `Atlantis.xcodeproj/project.pbxproj` (+534 -697) </details> ### 📄 Description Hey, Thank you so so much for Atlantis! I've been a big fan of Proxyman and I have been using since the beginning. I always wished for an easier way to capture traffic from test devices. I also often forgot to revert the proxy settings on the device and then wonder why it isn't connected anymore 🙄 ---- Anyway, I tried to publish an app to TestFlight but the validation doesn't pass. The framework was integrated by Carthage. ``` ERROR ITMS-90056: "This bundle Payload/Flighty Int.app/Frameworks/Atlantis.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion. Please find more information about CFBundleVersion at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion" ``` The framework bundle needs to include a value for `CFBundleVersion`. It was set to `CURRENT_PROJECT_VERSION` but that variable wasn't set in the project file. I set it to `1` for now, just to pass the App Store Connect validation. I also bumped the `CFBundleShortVersion` to 1.1.0 even though I don't think it will be used anywhere. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>