[PR #87] [MERGED] Add redis-url and redis-insecure-tls command line options #169

New issue

Closed

opened 2026-03-02 05:19:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 05:19:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynqmon/pull/87
Author: @gaffneyc
Created: 4/24/2021
Status: ✅ Merged
Merged: 4/26/2021
Merged by: @hibiken

Base: master ← Head: redis-url

📝 Commits (1)

5879945 Add redis-url and redis-insecure-tls command line options

📊 Changes

2 files changed (+53 additions, -23 deletions)

View changed files

📝 main.go (+52 -22)
📝 redis_info_handlers.go (+1 -1)

📄 Description

A URL can contain all of the information in the individual flags as a
single string rather than as separate pieces. I've mostly run into URLs
pointing to Redis and this make those existing URLs easier to work with.

This also introduces the -redis-insecure-tls flag which turns off TLS
certificate hostname verification. We've chosen Heroku Redis for a
recent project which requires TLS but, for reasons I don't know, they
don't provide a certificate that is valid for the hostname. I also
wasn't able to get the existing -redis-tls flag to work.

I've left the original flags for backwards compatibility but I also feel they're clunky and should be removed. The new flags use dashes (-) instead of underscores (_) since that's what I'm more use to with other commands in the Linux space. Didn't realize it until I was reviewing it for the PR but happy to change them.

On another note, thanks for Asynq. I spent a long time looking at alternative background job systems in Go and compared to everything else it's really well done and thought out. 🎉

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynqmon/pull/87 **Author:** [@gaffneyc](https://github.com/gaffneyc) **Created:** 4/24/2021 **Status:** ✅ Merged **Merged:** 4/26/2021 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `redis-url` --- ### 📝 Commits (1) - [`5879945`](https://github.com/hibiken/asynqmon/commit/5879945b866aa0d08063294d89f8df0079501769) Add redis-url and redis-insecure-tls command line options ### 📊 Changes **2 files changed** (+53 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `main.go` (+52 -22) 📝 `redis_info_handlers.go` (+1 -1) </details> ### 📄 Description A URL can contain all of the information in the individual flags as a single string rather than as separate pieces. I've mostly run into URLs pointing to Redis and this make those existing URLs easier to work with. This also introduces the -redis-insecure-tls flag which turns off TLS certificate hostname verification. We've chosen Heroku Redis for a recent project which requires TLS but, for reasons I don't know, they don't provide a certificate that is valid for the hostname. I also wasn't able to get the existing -redis-tls flag to work. I've left the original flags for backwards compatibility but I also feel they're clunky and should be removed. The new flags use dashes (-) instead of underscores (_) since that's what I'm more use to with other commands in the Linux space. Didn't realize it until I was reviewing it for the PR but happy to change them. On another note, thanks for Asynq. I spent a long time looking at alternative background job systems in Go and compared to everything else it's really well done and thought out. 🎉 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>