[PR #322] Allow configuring tls cert filepath #1030

Open
opened 2026-03-15 21:48:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynqmon/pull/322
Author: @nicksherron
Created: 2/28/2024
Status: 🔄 Open

Base: masterHead: master


📝 Commits (3)

  • 0223c44 Add ability to specify client certificate and key for redis connection
  • cca2f00 Update README.md with new redis tls options
  • 99f33bc Move tls certificate and ca cert configuring to makeTLSConfig function

📊 Changes

8 files changed (+412 additions, -8 deletions)

View changed files

📝 .gitignore (+4 -1)
📝 README.md (+3 -0)
📝 cmd/asynqmon/main.go (+48 -7)
📝 cmd/asynqmon/main_test.go (+266 -0)
cmd/asynqmon/testdata/ca.crt (+19 -0)
cmd/asynqmon/testdata/ca.key (+27 -0)
cmd/asynqmon/testdata/server.crt (+18 -0)
cmd/asynqmon/testdata/server.key (+27 -0)

📄 Description

This change allows setting tls cert and private key as well as ca authority file paths for configuring tls options for redis connection. Tests have also been added to test connecting to redis without tls and with using regeneratable custom tls keys

Flag Env Description Default
redis-ca-cert REDIS_CA_CERT path to CA certificate file used when connecting to redis server ""
redis-client-cert REDIS_CLIENT_CERT path to client certificate file used when connecting to redis server ""
redis-client-key REDIS_CLIENT_KEY path to client key file used when connecting to redis server ""

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynqmon/pull/322 **Author:** [@nicksherron](https://github.com/nicksherron) **Created:** 2/28/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`0223c44`](https://github.com/hibiken/asynqmon/commit/0223c44c82c4025e072e3656918d8e66a11a7e4c) Add ability to specify client certificate and key for redis connection - [`cca2f00`](https://github.com/hibiken/asynqmon/commit/cca2f0078805e257e5da430c488d1cd45c7463fb) Update README.md with new redis tls options - [`99f33bc`](https://github.com/hibiken/asynqmon/commit/99f33bc66ad4b9a278744f3140372194b276641f) Move tls certificate and ca cert configuring to makeTLSConfig function ### 📊 Changes **8 files changed** (+412 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+4 -1) 📝 `README.md` (+3 -0) 📝 `cmd/asynqmon/main.go` (+48 -7) 📝 `cmd/asynqmon/main_test.go` (+266 -0) ➕ `cmd/asynqmon/testdata/ca.crt` (+19 -0) ➕ `cmd/asynqmon/testdata/ca.key` (+27 -0) ➕ `cmd/asynqmon/testdata/server.crt` (+18 -0) ➕ `cmd/asynqmon/testdata/server.key` (+27 -0) </details> ### 📄 Description This change allows setting tls cert and private key as well as ca authority file paths for configuring tls options for redis connection. Tests have also been added to test connecting to redis without tls and with using regeneratable custom tls keys | Flag | Env | Description| Default | |--------------------|---------|------------|----------| |redis-ca-cert | REDIS_CA_CERT | path to CA certificate file used when connecting to redis server| "" | |redis-client-cert | REDIS_CLIENT_CERT | path to client certificate file used when connecting to redis server| "" | |redis-client-key | REDIS_CLIENT_KEY | path to client key file used when connecting to redis server| "" | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asynqmon#1030
No description provided.