[PR #271] Properly use Redis and Sentinel password #1008

New issue

Open

opened 2026-03-15 21:46:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 21:46:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynqmon/pull/271
Author: @akhy
Created: 9/27/2022
Status: 🔄 Open

Base: master ← Head: redis-sentinel-config-fix

📝 Commits (4)

5111aa4 Properly separate Redis and Sentinel password
1684449 Update asynq deps
de1b35a Upgrade asynq deps
9078639 Merge remote-tracking branch 'upstream/master' into redis-sentinel-config-fix

📊 Changes

2 files changed (+18 additions, -2 deletions)

View changed files

📝 cmd/asynqmon/main.go (+1 -0)
📝 cmd/asynqmon/main_test.go (+17 -2)

📄 Description

This is to follow up with changes from https://github.com/hibiken/asynq/pull/537 from @sillydong

Updated the tests to show the correct expected behavior from above PR. But since the PR has not released yet, I added a temporary workaround in main.go to make the tests pass.

Will remove the workaround and update deps once https://github.com/hibiken/asynq/pull/537 has tag release. @hibiken You might not want to merge this PR until then.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynqmon/pull/271 **Author:** [@akhy](https://github.com/akhy) **Created:** 9/27/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `redis-sentinel-config-fix` --- ### 📝 Commits (4) - [`5111aa4`](https://github.com/hibiken/asynqmon/commit/5111aa4f217acb73269511a2694f91899940f289) Properly separate Redis and Sentinel password - [`1684449`](https://github.com/hibiken/asynqmon/commit/1684449cd7ea4e0b568f3edadafc8bfe855d326d) Update asynq deps - [`de1b35a`](https://github.com/hibiken/asynqmon/commit/de1b35abb20b8fa6f78a99005abd17562321802e) Upgrade asynq deps - [`9078639`](https://github.com/hibiken/asynqmon/commit/90786395a8456a0b19f999e43e2fb8492b6fcc21) Merge remote-tracking branch 'upstream/master' into redis-sentinel-config-fix ### 📊 Changes **2 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/asynqmon/main.go` (+1 -0) 📝 `cmd/asynqmon/main_test.go` (+17 -2) </details> ### 📄 Description This is to follow up with changes from https://github.com/hibiken/asynq/pull/537 from @sillydong Updated the tests to show the correct expected behavior from above PR. But since the PR has not released yet, I added a temporary workaround in `main.go` to make the tests pass. Will remove the workaround and update deps once https://github.com/hibiken/asynq/pull/537 has tag release. @hibiken You might not want to merge this PR until then. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>