[PR #1005] [CLOSED] fix compatible with redis server verison 4.0 #974

New issue

Closed

opened 2026-03-02 06:10:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 06:10:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/1005
Author: @popstk
Created: 1/10/2025
Status: ❌ Closed

Base: master ← Head: bugfix/compatibility-redis-verison

📝 Commits (1)

fea9807 fix

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 internal/rdb/rdb.go (+1 -1)

📄 Description

as readme say Version 4.0 or higher is required, but zrange xxx byscore add from version 6.2.0

https://redis.io/docs/latest/commands/zrange/
Starting with Redis version 6.2.0: Added the REV, BYSCORE, BYLEX and LIMIT options.

in addition,
github.com/hibiken/asynq@489e21920b/processor.go (L381)

	err := p.broker.Archive(ctx, msg, e.Error())
	if err != nil {

The err do not print in log, it makes lua err debuging need more time

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/1005 **Author:** [@popstk](https://github.com/popstk) **Created:** 1/10/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bugfix/compatibility-redis-verison` --- ### 📝 Commits (1) - [`fea9807`](https://github.com/hibiken/asynq/commit/fea98072d394fdea96c1f2ebc7871df116ac2760) fix ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/rdb/rdb.go` (+1 -1) </details> ### 📄 Description as readme say `Version 4.0 or higher is required`, but `zrange xxx byscore ` add from version 6.2.0 >> https://redis.io/docs/latest/commands/zrange/ >> Starting with Redis version 6.2.0: Added the REV, BYSCORE, BYLEX and LIMIT options. --- in addition, https://github.com/hibiken/asynq/blob/489e21920b92ae6acfc19c54de91166e56817620/processor.go#L381 ``` go err := p.broker.Archive(ctx, msg, e.Error()) if err != nil { ``` The `err` do not print in log, it makes lua err debuging need more time --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>