[PR #945] [MERGED] Update tests to use the configured Redis address #937

New issue

Closed

opened 2026-03-02 06:10:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 06:10:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/945
Author: @pior
Created: 10/28/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @kamikazechaser

Base: master ← Head: fix-test-default-port

📝 Commits (1)

04b3a34 Update tests to use the configured Redis address

📊 Changes

3 files changed (+33 additions, -36 deletions)

View changed files

📝 periodic_task_manager_test.go (+26 -29)
📝 scheduler_test.go (+2 -2)
📝 server_test.go (+5 -5)

📄 Description

Context

I'm running tests locally with go test -redis_addr ${REDIS_HOST}:${REDIS_PORT} -v -race -cover ./... because my machine is configured with isolated Redis instances per project.

Most tests are attempting to connect to the Redis address specified by flags, but not all

Changes

Update a bunch of tests to connect to Redis as specified by -redis_addr

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/945 **Author:** [@pior](https://github.com/pior) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 10/29/2024 **Merged by:** [@kamikazechaser](https://github.com/kamikazechaser) **Base:** `master` ← **Head:** `fix-test-default-port` --- ### 📝 Commits (1) - [`04b3a34`](https://github.com/hibiken/asynq/commit/04b3a3475d2f213f93f58f48e47a35ecf59673fa) Update tests to use the configured Redis address ### 📊 Changes **3 files changed** (+33 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `periodic_task_manager_test.go` (+26 -29) 📝 `scheduler_test.go` (+2 -2) 📝 `server_test.go` (+5 -5) </details> ### 📄 Description ## Context I'm running tests locally with `go test -redis_addr ${REDIS_HOST}:${REDIS_PORT} -v -race -cover ./...` because my machine is configured with isolated Redis instances per project. Most tests are attempting to connect to the Redis address specified by flags, but not all ## Changes - Update a bunch of tests to connect to Redis as specified by `-redis_addr` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>