[PR #843] [MERGED] Fix go:build for BSD #895

New issue

Closed

opened 2026-03-02 06:10:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 06:10:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/843
Author: @mrusme
Created: 3/14/2024
Status: ✅ Merged
Merged: 3/15/2024
Merged by: @kamikazechaser

Base: master ← Head: fix-bsd

📝 Commits (1)

b25d10b Fixed go:build for BSD

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 signals_unix.go (+1 -1)

📄 Description

I've been running into the following build issue on a project that uses asynq:

  ⨯ release failed after 5m12s               error=failed to build for openbsd_386: exit status 1: # github.com/hibiken/asynq
Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/periodic_task_manager.go:152:8: mgr.s.waitForSignals undefined (type *Scheduler has no field or method waitForSignals)
Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/scheduler.go:212:4: s.waitForSignals undefined (type *Scheduler has no field or method waitForSignals)
Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/server.go:594:6: srv.waitForSignals undefined (type *Server has no field or method waitForSignals)
Error: The process '/opt/hostedtoolcache/goreleaser-action/1.24.0/x64/goreleaser' failed with exit code 1

Upon fruther investigation it appears that the go:build flag bsd is not correct. The go tool dist list command doesn't list any platform named bsd. Hence I believe bsd needs to be replaced with the actual BSD platforms. I don't know whether you would want to include solaris as well, and whether there's anyone using it/able to test it on that platform, hence I left it out.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/843 **Author:** [@mrusme](https://github.com/mrusme) **Created:** 3/14/2024 **Status:** ✅ Merged **Merged:** 3/15/2024 **Merged by:** [@kamikazechaser](https://github.com/kamikazechaser) **Base:** `master` ← **Head:** `fix-bsd` --- ### 📝 Commits (1) - [`b25d10b`](https://github.com/hibiken/asynq/commit/b25d10b61d545dcfa98efdecd946f84889e40319) Fixed go:build for BSD ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `signals_unix.go` (+1 -1) </details> ### 📄 Description I've been running into the following build issue on a project that uses asynq: ```log ⨯ release failed after 5m12s error=failed to build for openbsd_386: exit status 1: # github.com/hibiken/asynq Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/periodic_task_manager.go:152:8: mgr.s.waitForSignals undefined (type *Scheduler has no field or method waitForSignals) Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/scheduler.go:212:4: s.waitForSignals undefined (type *Scheduler has no field or method waitForSignals) Error: ../../../go/pkg/mod/github.com/hibiken/asynq@v0.24.1/server.go:594:6: srv.waitForSignals undefined (type *Server has no field or method waitForSignals) Error: The process '/opt/hostedtoolcache/goreleaser-action/1.24.0/x64/goreleaser' failed with exit code 1 ``` Upon fruther investigation it appears that the `go:build` flag `bsd` is not correct. The `go tool dist list` command doesn't list any platform named `bsd`. Hence I believe `bsd` needs to be replaced with the actual BSD platforms. I don't know whether you would want to include `solaris` as well, and whether there's anyone using it/able to test it on that platform, hence I left it out. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>