[PR #638] [CLOSED] fix: fix panic when redis client closed before server closed #801

Closed
opened 2026-03-02 06:05:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/638
Author: @bfwbbrj
Created: 4/6/2023
Status: Closed

Base: masterHead: fix/redis-client-closed


📝 Commits (1)

  • 3fbad36 fix: fix panic when redis client closed before server closed

📊 Changes

2 files changed (+38 additions, -1 deletions)

View changed files

📝 subscriber.go (+6 -1)
📝 subscriber_test.go (+32 -0)

📄 Description

As mentioned in #635 , closing the redis client before shut down asynq will cause panic in subscriber


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/638 **Author:** [@bfwbbrj](https://github.com/bfwbbrj) **Created:** 4/6/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/redis-client-closed` --- ### 📝 Commits (1) - [`3fbad36`](https://github.com/hibiken/asynq/commit/3fbad36a4cd119bc04274df3f5a415ae1b5cea58) fix: fix panic when redis client closed before server closed ### 📊 Changes **2 files changed** (+38 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `subscriber.go` (+6 -1) 📝 `subscriber_test.go` (+32 -0) </details> ### 📄 Description As mentioned in #635 , closing the redis client before shut down asynq will cause panic in [subscriber](https://github.com/hibiken/asynq/blob/cc777ebdaa62b69bd6e985fa97117b854e7d1cd6/subscriber.go#L83) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 06:05:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asynq#801
No description provided.