[PR #386] [MERGED] Add support for deriving context for TaskHandler #730

Closed
opened 2026-03-02 06:05:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/386
Author: @binaek
Created: 1/25/2022
Status: Merged
Merged: 2/16/2022
Merged by: @hibiken

Base: masterHead: custom_context


📝 Commits (4)

📊 Changes

5 files changed (+64 additions, -7 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 internal/context/context.go (+2 -2)
📝 internal/context/context_test.go (+42 -3)
📝 processor.go (+5 -2)
📝 server.go (+11 -0)

📄 Description

@hibiken: For #381 , I wrote up a reference implementation for deriving contexts for task handlers. Not sure if this follows your code conventions. Let me know what changes you need to meet asynq standards


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/386 **Author:** [@binaek](https://github.com/binaek) **Created:** 1/25/2022 **Status:** ✅ Merged **Merged:** 2/16/2022 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `custom_context` --- ### 📝 Commits (4) - [`a18c0bc`](https://github.com/hibiken/asynq/commit/a18c0bc958806bce367150d83c42a750bab66f52) first cut - [`a5d42ad`](https://github.com/hibiken/asynq/commit/a5d42adaed14f5aac745b4988b7ef4d17d2846a4) review corrections - [`2499cd9`](https://github.com/hibiken/asynq/commit/2499cd95a82b845817fde1494e8c4cd473586fb7) test and changelog - [`70f9ba2`](https://github.com/hibiken/asynq/commit/70f9ba2db81043d491dfcbde80a565c352d54a21) conventions ### 📊 Changes **5 files changed** (+64 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `internal/context/context.go` (+2 -2) 📝 `internal/context/context_test.go` (+42 -3) 📝 `processor.go` (+5 -2) 📝 `server.go` (+11 -0) </details> ### 📄 Description @hibiken: For #381 , I wrote up a reference implementation for deriving contexts for task handlers. Not sure if this follows your code conventions. Let me know what changes you need to meet `asynq` standards --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 06:05:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asynq#730
No description provided.