[PR #298] [MERGED] Upgrade go-redis/redis to version 8 #704

New issue

Closed

opened 2026-03-02 06:05:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 06:05:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/298
Author: @strobus
Created: 7/20/2021
Status: ✅ Merged
Merged: 9/2/2021
Merged by: @hibiken

Base: master ← Head: upgrade-go-redis-to-v8

📝 Commits (8)

afd3506 upgrade go-redis/redis to version 8
78e23f1 added loglevel flag back; inadvertently deleted
c2552b2 Revert "added loglevel flag back; inadvertently deleted"
3433315 Revert "upgrade go-redis/redis to version 8"
0f32aca upgrade go-redis/redis to v8
626e626 use new context at call point instead of global context variable
39a9689 rename ctx2 to ctx
4488a5d merge from master

📊 Changes

24 files changed (+331 additions, -304 deletions)

View changed files

📝 asynq.go (+1 -1)
📝 asynq_test.go (+1 -1)
📝 client.go (+1 -1)
📝 client_test.go (+4 -3)
📝 go.mod (+7 -5)
📝 go.sum (+57 -33)
📝 inspector.go (+1 -1)
📝 inspector_test.go (+8 -7)
📝 internal/asynqtest/asynqtest.go (+26 -25)
📝 internal/base/base.go (+1 -1)
📝 internal/rdb/inspect.go (+41 -40)
📝 internal/rdb/inspect_test.go (+16 -15)
📝 internal/rdb/rdb.go (+24 -23)
📝 internal/rdb/rdb_test.go (+60 -59)
📝 internal/testbroker/testbroker.go (+1 -1)
📝 processor_test.go (+5 -5)
📝 scheduler.go (+1 -1)
📝 server.go (+1 -1)
📝 server_test.go (+2 -2)
📝 subscriber.go (+1 -1)

...and 4 more files

📄 Description

This PR upgrade the go-redis/redis/v7 dependency to go-redis/redis/v8. The major change between the two versions is that all methods that interact with the redis server have a context.Context parameter added. These context parameters have been surfaced up to the exported asynq interfaces.

Edit: resolves issue https://github.com/hibiken/asynq/issues/293

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/298 **Author:** [@strobus](https://github.com/strobus) **Created:** 7/20/2021 **Status:** ✅ Merged **Merged:** 9/2/2021 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `upgrade-go-redis-to-v8` --- ### 📝 Commits (8) - [`afd3506`](https://github.com/hibiken/asynq/commit/afd3506be84a8e6f7bc0940ed0a264d8c900163c) upgrade go-redis/redis to version 8 - [`78e23f1`](https://github.com/hibiken/asynq/commit/78e23f1867bd7093cb853ba8d6045e0e91037107) added loglevel flag back; inadvertently deleted - [`c2552b2`](https://github.com/hibiken/asynq/commit/c2552b2954c0632d1b622d6a5bf2853c7da1cff4) Revert "added loglevel flag back; inadvertently deleted" - [`3433315`](https://github.com/hibiken/asynq/commit/343331588490105a1bef0e81db35056d93a31082) Revert "upgrade go-redis/redis to version 8" - [`0f32aca`](https://github.com/hibiken/asynq/commit/0f32aca3fca95857b2a3e4bfb0b5ce317a880810) upgrade go-redis/redis to v8 - [`626e626`](https://github.com/hibiken/asynq/commit/626e626058b40f6c0f5b65bbb292a9a6bff4706c) use new context at call point instead of global context variable - [`39a9689`](https://github.com/hibiken/asynq/commit/39a96893362be39a58d0a2cf11da6f9de0c0fcd5) rename ctx2 to ctx - [`4488a5d`](https://github.com/hibiken/asynq/commit/4488a5d8cadb5a875d571588f5cf23f5b4a163ff) merge from master ### 📊 Changes **24 files changed** (+331 additions, -304 deletions) <details> <summary>View changed files</summary> 📝 `asynq.go` (+1 -1) 📝 `asynq_test.go` (+1 -1) 📝 `client.go` (+1 -1) 📝 `client_test.go` (+4 -3) 📝 `go.mod` (+7 -5) 📝 `go.sum` (+57 -33) 📝 `inspector.go` (+1 -1) 📝 `inspector_test.go` (+8 -7) 📝 `internal/asynqtest/asynqtest.go` (+26 -25) 📝 `internal/base/base.go` (+1 -1) 📝 `internal/rdb/inspect.go` (+41 -40) 📝 `internal/rdb/inspect_test.go` (+16 -15) 📝 `internal/rdb/rdb.go` (+24 -23) 📝 `internal/rdb/rdb_test.go` (+60 -59) 📝 `internal/testbroker/testbroker.go` (+1 -1) 📝 `processor_test.go` (+5 -5) 📝 `scheduler.go` (+1 -1) 📝 `server.go` (+1 -1) 📝 `server_test.go` (+2 -2) 📝 `subscriber.go` (+1 -1) _...and 4 more files_ </details> ### 📄 Description This PR upgrade the `go-redis/redis/v7` dependency to `go-redis/redis/v8`. The major change between the two versions is that all methods that interact with the redis server have a `context.Context` parameter added. These context parameters have been surfaced up to the exported `asynq` interfaces. Edit: resolves issue https://github.com/hibiken/asynq/issues/293 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>