[PR #148] [MERGED] Simplify Logger interface #634

New issue

Closed

opened 2026-03-02 05:54:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 05:54:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/148
Author: @hibiken
Created: 5/6/2020
Status: ✅ Merged
Merged: 5/11/2020
Merged by: @hibiken

Base: next ← Head: api/logger

📝 Commits (5)

37de0a5 Simplify Logger interface
cf74c61 Allow setting minimum log level for logger
13aca94 Change LogLevel to satisfy flag.Value interface
958581c Update changelog
e73fc41 Define test flags for package testing

📊 Changes

11 files changed (+616 additions, -108 deletions)

View changed files

📝 CHANGELOG.md (+8 -0)
📝 asynq_test.go (+20 -8)
📝 heartbeat.go (+4 -3)
📝 internal/log/log.go (+180 -22)
📝 internal/log/log_test.go (+267 -32)
📝 processor.go (+12 -11)
📝 scheduler.go (+4 -3)
📝 server.go (+77 -18)
📝 server_test.go (+36 -6)
📝 subscriber.go (+4 -3)
📝 syncer.go (+4 -2)

📄 Description

Closes #147
Closes #143

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/148 **Author:** [@hibiken](https://github.com/hibiken) **Created:** 5/6/2020 **Status:** ✅ Merged **Merged:** 5/11/2020 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `next` ← **Head:** `api/logger` --- ### 📝 Commits (5) - [`37de0a5`](https://github.com/hibiken/asynq/commit/37de0a52738d8e85d3758959f6b3936249777192) Simplify Logger interface - [`cf74c61`](https://github.com/hibiken/asynq/commit/cf74c61233541f03d80fd7535282c093501e5f66) Allow setting minimum log level for logger - [`13aca94`](https://github.com/hibiken/asynq/commit/13aca94a4a410a5246d1de9b6eadf7ebd37bb425) Change LogLevel to satisfy flag.Value interface - [`958581c`](https://github.com/hibiken/asynq/commit/958581c64c6aad3810f3490a5b785388e6be95fa) Update changelog - [`e73fc41`](https://github.com/hibiken/asynq/commit/e73fc41a7fd88569a7d987294500cffd6c88de19) Define test flags for package testing ### 📊 Changes **11 files changed** (+616 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+8 -0) 📝 `asynq_test.go` (+20 -8) 📝 `heartbeat.go` (+4 -3) 📝 `internal/log/log.go` (+180 -22) 📝 `internal/log/log_test.go` (+267 -32) 📝 `processor.go` (+12 -11) 📝 `scheduler.go` (+4 -3) 📝 `server.go` (+77 -18) 📝 `server_test.go` (+36 -6) 📝 `subscriber.go` (+4 -3) 📝 `syncer.go` (+4 -2) </details> ### 📄 Description Closes #147 Closes #143 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>