[PR #44] [MERGED] Make Task type immutable #565

Closed
opened 2026-03-02 05:54:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/44
Author: @hibiken
Created: 1/5/2020
Status: Merged
Merged: 1/5/2020
Merged by: @hibiken

Base: masterHead: change/task_api


📝 Commits (3)

  • c1ef571 Make Task type immutable
  • a4adfe3 Add test for payload key not exist
  • 82abe0e [ci skip] Update readme

📊 Changes

14 files changed (+191 additions, -350 deletions)

View changed files

📝 CHANGELOG.md (+8 -0)
📝 README.md (+25 -19)
📝 asynq.go (+12 -1)
📝 background.go (+1 -4)
📝 background_test.go (+3 -9)
📝 benchmark_test.go (+6 -6)
📝 client.go (+1 -1)
📝 client_test.go (+6 -6)
📝 doc.go (+4 -5)
📝 internal/rdb/rdb_test.go (+0 -262)
📝 payload.go (+17 -16)
📝 payload_test.go (+98 -11)
📝 processor.go (+2 -2)
📝 processor_test.go (+8 -8)

📄 Description

This change makes it impossible to mutate payload within Handler or RetryDelayFunc.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/44 **Author:** [@hibiken](https://github.com/hibiken) **Created:** 1/5/2020 **Status:** ✅ Merged **Merged:** 1/5/2020 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `change/task_api` --- ### 📝 Commits (3) - [`c1ef571`](https://github.com/hibiken/asynq/commit/c1ef571d163e89271c2ba13f4f603064e50a4b22) Make Task type immutable - [`a4adfe3`](https://github.com/hibiken/asynq/commit/a4adfe355aa5fe991414238a934041c9b3d676de) Add test for payload key not exist - [`82abe0e`](https://github.com/hibiken/asynq/commit/82abe0e4c495e197291e069f915b6f60d8b12a7b) [ci skip] Update readme ### 📊 Changes **14 files changed** (+191 additions, -350 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+8 -0) 📝 `README.md` (+25 -19) 📝 `asynq.go` (+12 -1) 📝 `background.go` (+1 -4) 📝 `background_test.go` (+3 -9) 📝 `benchmark_test.go` (+6 -6) 📝 `client.go` (+1 -1) 📝 `client_test.go` (+6 -6) 📝 `doc.go` (+4 -5) 📝 `internal/rdb/rdb_test.go` (+0 -262) 📝 `payload.go` (+17 -16) 📝 `payload_test.go` (+98 -11) 📝 `processor.go` (+2 -2) 📝 `processor_test.go` (+8 -8) </details> ### 📄 Description This change makes it impossible to mutate payload within Handler or RetryDelayFunc. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 05:54:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asynq#565
No description provided.