[PR #4] [MERGED] Create an internal package for reuse #532

New issue

Closed

opened 2026-03-02 05:38:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 05:38:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/4
Author: @hibiken
Created: 12/1/2019
Status: ✅ Merged
Merged: 12/6/2019
Merged by: @hibiken

Base: master ← Head: feature/inspector

📝 Commits (10+)

9c2d2a6 Create Inspector
5446f87 Add List* methods to Inspector
28dae0f Add task types specific to each queue
319d157 Change inspector's list methods to return specific task type for each
593f2b0 Add command "asynqmon" for monitoring
d4e442d Extract rdb to internal package
39f177d Change rdb Dequeue signature
985018e Rename rdb Remove to Done
4531e90 Define Schedule and RetryLater method for RDB
318b24b Rename MoveAll to RestoreUnfinished

📊 Changes

17 files changed (+1115 additions, -694 deletions)

View changed files

📝 asynq.go (+9 -27)
📝 asynq_test.go (+28 -34)
📝 background.go (+8 -6)
📝 client.go (+8 -6)
📝 client_test.go (+7 -6)
➕ cmd/asynqmon/main.go (+43 -0)
📝 go.sum (+9 -0)
➕ internal/rdb/rdb.go (+406 -0)
➕ internal/rdb/rdb_test.go (+489 -0)
📝 poller.go (+7 -11)
📝 poller_test.go (+29 -27)
📝 processor.go (+12 -10)
📝 processor_test.go (+36 -33)
➖ rdb.go (+0 -156)
➖ rdb_test.go (+0 -358)
📝 retry.go (+5 -3)
📝 retry_test.go (+19 -17)

📄 Description

Extracted rdb to its own package and put it in internal so that it can be shared with monitoring command program and core library.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/4 **Author:** [@hibiken](https://github.com/hibiken) **Created:** 12/1/2019 **Status:** ✅ Merged **Merged:** 12/6/2019 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `feature/inspector` --- ### 📝 Commits (10+) - [`9c2d2a6`](https://github.com/hibiken/asynq/commit/9c2d2a612dbde6f14daef4270600fe569a42396d) Create Inspector - [`5446f87`](https://github.com/hibiken/asynq/commit/5446f877ceb7118862109313cc88133600224136) Add List* methods to Inspector - [`28dae0f`](https://github.com/hibiken/asynq/commit/28dae0fdd35064971a91afb6efec9256be27e0bf) Add task types specific to each queue - [`319d157`](https://github.com/hibiken/asynq/commit/319d157d47f4b8d34e2022e29735bef7183345e0) Change inspector's list methods to return specific task type for each - [`593f2b0`](https://github.com/hibiken/asynq/commit/593f2b04824f6cb5356f7cbd04c1c86916c4dc75) Add command "asynqmon" for monitoring - [`d4e442d`](https://github.com/hibiken/asynq/commit/d4e442d04fafd1bbf06501c07aeef51438ae17df) Extract rdb to internal package - [`39f177d`](https://github.com/hibiken/asynq/commit/39f177dabff40c12a83de1fa01cd458d2042fd76) Change rdb Dequeue signature - [`985018e`](https://github.com/hibiken/asynq/commit/985018e1b5ccc189ae00c616869e7e7bdb0636a4) Rename rdb Remove to Done - [`4531e90`](https://github.com/hibiken/asynq/commit/4531e90b9d0df0625bbb4b3b5947bd6c2585a9f0) Define Schedule and RetryLater method for RDB - [`318b24b`](https://github.com/hibiken/asynq/commit/318b24b3b8b8fd3a002ea9d3d24a9601b1318faf) Rename MoveAll to RestoreUnfinished ### 📊 Changes **17 files changed** (+1115 additions, -694 deletions) <details> <summary>View changed files</summary> 📝 `asynq.go` (+9 -27) 📝 `asynq_test.go` (+28 -34) 📝 `background.go` (+8 -6) 📝 `client.go` (+8 -6) 📝 `client_test.go` (+7 -6) ➕ `cmd/asynqmon/main.go` (+43 -0) 📝 `go.sum` (+9 -0) ➕ `internal/rdb/rdb.go` (+406 -0) ➕ `internal/rdb/rdb_test.go` (+489 -0) 📝 `poller.go` (+7 -11) 📝 `poller_test.go` (+29 -27) 📝 `processor.go` (+12 -10) 📝 `processor_test.go` (+36 -33) ➖ `rdb.go` (+0 -156) ➖ `rdb_test.go` (+0 -358) 📝 `retry.go` (+5 -3) 📝 `retry_test.go` (+19 -17) </details> ### 📄 Description Extracted rdb to its own package and put it in `internal` so that it can be shared with monitoring command program and core library. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>