[GH-ISSUE #618] [BUG] Wiki docs use "SetDefaultOptions" when it's deprecated #302

Closed
opened 2026-03-02 05:20:19 +03:00 by kerem · 2 comments
Owner

Originally created by @sushi30 on GitHub (Feb 21, 2023).
Original GitHub issue: https://github.com/hibiken/asynq/issues/618

Originally assigned to: @hibiken on GitHub.

Describe the bug
It appears SetDefaultOptions was deprecated. It is still referenced in the docs: https://github.com/hibiken/asynq/wiki/Task-Retry#customize-task-max-retry

I did not change because I am a new user to the library so I am not sure what is the correct fix for this doc.

Originally created by @sushi30 on GitHub (Feb 21, 2023). Original GitHub issue: https://github.com/hibiken/asynq/issues/618 Originally assigned to: @hibiken on GitHub. **Describe the bug** It appears `SetDefaultOptions` was deprecated. It is still referenced in the docs: https://github.com/hibiken/asynq/wiki/Task-Retry#customize-task-max-retry I did not change because I am a new user to the library so I am not sure what is the correct fix for this doc.
kerem 2026-03-02 05:20:19 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@fivezjd commented on GitHub (Mar 10, 2023):

The latest version has three methods to set MaxRetry:

  • t1 := NewTask("shometype", nil, MaxRetry(10))
  • client.Enqueue(t1, MaxRetry(10))
  • client.EnqueueContext(context.Background(), t1, MaxRetry(10))
    The latter two methods will override the former one. here
<!-- gh-comment-id:1463204931 --> @fivezjd commented on GitHub (Mar 10, 2023): The latest version has three methods to set MaxRetry: - `t1 := NewTask("shometype", nil, MaxRetry(10))` - `client.Enqueue(t1, MaxRetry(10))` - `client.EnqueueContext(context.Background(), t1, MaxRetry(10))` The latter two methods will override the former one. [here](https://github.com/hibiken/asynq/blob/cc777ebdaa62b69bd6e985fa97117b854e7d1cd6/client.go#L246)
Author
Owner

@hibiken commented on GitHub (Apr 7, 2023):

Thanks for reporting this issue. Fixed :)

<!-- gh-comment-id:1499899191 --> @hibiken commented on GitHub (Apr 7, 2023): Thanks for reporting this issue. Fixed :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asynq#302
No description provided.