[PR #1047] [MERGED] wrap all fmt.Errorf errors #3016

New issue

Closed

opened 2026-03-15 21:15:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 21:15:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/1047
Author: @benjajaja
Created: 5/14/2025
Status: ✅ Merged
Merged: 11/4/2025
Merged by: @kamikazechaser

Base: master ← Head: wrap_errors

📝 Commits (1)

397ed11 wrap all fmt.Errorf errors

📊 Changes

6 files changed (+31 additions, -31 deletions)

View changed files

📝 asynq.go (+2 -2)
📝 example_test.go (+1 -1)
📝 inspector.go (+21 -21)
📝 periodic_task_manager.go (+4 -4)
📝 x/metrics/metrics.go (+2 -2)
📝 x/rate/semaphore.go (+1 -1)

📄 Description

Users need to be able to match with errors.Is() also on external errors, for example context.Canceled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/1047 **Author:** [@benjajaja](https://github.com/benjajaja) **Created:** 5/14/2025 **Status:** ✅ Merged **Merged:** 11/4/2025 **Merged by:** [@kamikazechaser](https://github.com/kamikazechaser) **Base:** `master` ← **Head:** `wrap_errors` --- ### 📝 Commits (1) - [`397ed11`](https://github.com/hibiken/asynq/commit/397ed1166cfcb2747b34a59153d8986a902e966b) wrap all fmt.Errorf errors ### 📊 Changes **6 files changed** (+31 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `asynq.go` (+2 -2) 📝 `example_test.go` (+1 -1) 📝 `inspector.go` (+21 -21) 📝 `periodic_task_manager.go` (+4 -4) 📝 `x/metrics/metrics.go` (+2 -2) 📝 `x/rate/semaphore.go` (+1 -1) </details> ### 📄 Description Users need to be able to match with `errors.Is()` also on external errors, for example `context.Canceled`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 21:15:43 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#3016

No description provided.

Rows
Columns