starred/asynq

Fork 0

mirror of https://github.com/hibiken/asynq.git synced 2026-04-25 23:15:51 +03:00

x #3015

New issue

Open

opened 2026-03-15 21:15:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 21:15:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/1032
Author: @dependabot[bot]
Created: 3/10/2025
Status: 🔄 Open

Base: master ← Head: dependabot/go_modules/x/github.com/prometheus/client_golang-1.21.1

📝 Commits (1)

25f1e3d build(deps): bump github.com/prometheus/client_golang in /x

📊 Changes

2 files changed (+22 additions, -14 deletions)

View changed files

📝 x/go.mod (+4 -4)
📝 x/go.sum (+18 -10)

📄 Description

Bumps github.com/prometheus/client_golang from 1.20.5 to 1.21.1.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.21.1 / 2025-03-04

This release addresses a performance regression introduced in #1661 -- thanks to all who reported this quickly: @chlunde, @dethi, @aaronbee @tsuna @kakkoyun 💪🏽. This patch release also fixes the iOS build.

We will be hardening the release process even further (#1759, #1761) to prevent this in future, sorry for the inconvenience!

The high concurrency optimization is planned to be eventually reintroduced, however in a much safer manner, potentially in a separate API.

[BUGFIX] prometheus: Revert of Inc, Add and Observe cumulative metric CAS optimizations (#1661), causing regressions on low concurrency cases #1757

[BUGFIX] prometheus: Fix GOOS=ios build, broken due to process_collector_* wrong build tags. #1758

Revert "exponential backoff for CAS operations on floats" and cut 1.21.1 by @bwplotka in prometheus/client_golang#1757

Fix ios build for 1.21.1 by @bwplotka in prometheus/client_golang#1758

Full Changelog: https://github.com/prometheus/client_golang/compare/v1.21.0...v1.21.1

v1.21.0 / 2025-02-19

⚠️ This release contains potential breaking change if you upgrade github.com/prometheus/common to 0.62+ together with client_golang (and depend on the strict, legacy validation for the label names). New common version changes model.NameValidationScheme global variable, which relaxes the validation of label names and metric name, allowing all UTF-8 characters. Typically, this should not break any user, unless your test or usage expects strict certain names to panic/fail on client_golang metric registration, gathering or scrape. In case of problems change model.NameValidationScheme to old model.LegacyValidation value in your project init function. ⚠️

[BUGFIX] gocollector: Fix help message for runtime/metric metrics. #1583

[BUGFIX] prometheus: Fix Desc.String() method for no labels case. #1687

[PERF] prometheus: Optimize popular prometheus.BuildFQName function; now up to 30% faster. #1665

[PERF] prometheus: Optimize Inc, Add and Observe cumulative metrics; now up to 50% faster under high concurrent contention. #1661

[CHANGE] Upgrade prometheus/common to 0.62.0 which changes model.NameValidationScheme global variable. #1712

[CHANGE] Add support for Go 1.23. #1602

[FEATURE] process_collector: Add support for Darwin systems. #1600 #1616 #1625 #1675 #1715

[FEATURE] api: Add ability to invoke CloseIdleConnections on api.Client using api.Client.(CloseIdler).CloseIdleConnections() casting. #1513

[FEATURE] promhttp: Add promhttp.HandlerOpts.EnableOpenMetricsTextCreatedSamples option to create OpenMetrics _created lines. Not recommended unless you want to use opt-in Created Timestamp feature. Community works on OpenMetrics 2.0 format that should make those lines obsolete (they increase cardinality significantly). #1408

[FEATURE] prometheus: Add NewConstNativeHistogram function. #1654

... (truncated)

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.21.1 / 2025-03-04

[BUGFIX] prometheus: Revert of Inc, Add and Observe cumulative metric CAS optimizations (#1661), causing regressions on low contention cases.

[BUGFIX] prometheus: Fix GOOS=ios build, broken due to process_collector_* wrong build tags.

1.21.0 / 2025-02-17

⚠️ This release contains potential breaking change if you upgrade github.com/prometheus/common to 0.62+ together with client_golang. ⚠️

New common version changes model.NameValidationScheme global variable, which relaxes the validation of label names and metric name, allowing all UTF-8 characters. Typically, this should not break any user, unless your test or usage expects strict certain names to panic/fail on client_golang metric registration, gathering or scrape. In case of problems change model.NameValidationScheme to old model.LegacyValidation value in your project init function.

[BUGFIX] gocollector: Fix help message for runtime/metric metrics. #1583

[BUGFIX] prometheus: Fix Desc.String() method for no labels case. #1687

[ENHANCEMENT] prometheus: Optimize popular prometheus.BuildFQName function; now up to 30% faster. #1665

[ENHANCEMENT] prometheus: Optimize Inc, Add and Observe cumulative metrics; now up to 50% faster under high concurrent contention. #1661

[CHANGE] Upgrade prometheus/common to 0.62.0 which changes model.NameValidationScheme global variable. #1712

[CHANGE] Add support for Go 1.23. #1602

[FEATURE] process_collector: Add support for Darwin systems. #1600 #1616 #1625 #1675 #1715

[FEATURE] api: Add ability to invoke CloseIdleConnections on api.Client using api.Client.(CloseIdler).CloseIdleConnections() casting. #1513

[FEATURE] promhttp: Add promhttp.HandlerOpts.EnableOpenMetricsTextCreatedSamples option to create OpenMetrics _created lines. Not recommended unless you want to use opt-in Created Timestamp feature. Community works on OpenMetrics 2.0 format that should make those lines obsolete (they increase cardinality significantly). #1408

[FEATURE] prometheus: Add NewConstNativeHistogram function. #1654

Commits

8a42da3 Fix ios build. (#1758)
40c62f7 Merge pull request #1757 from prometheus/revert-121cas
689f590 Cut 1.21.1
9e567a7 Revert "Add: exponential backoff for CAS operations on floats (#1661)"
eaf03ef Cut 1.21.0 (#1737)
f1f89dc Cut 1.21.0-rc.0 (#1718)
c923f7c Revert "ci: daggerize test and lint pipelines (#1534)" (#1717)
1bcda80 process collector: Fixed pedantic registry failures on darwin with cgo. (#1715)
038b37a tutorials/whatsup: Updated deps (#1716)
56a2431 docs: Add RELEASE.md for the release process (#1690)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/1032 **Author:** [@dependabot[bot]](https://github.com/apps/dependabot) **Created:** 3/10/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `dependabot/go_modules/x/github.com/prometheus/client_golang-1.21.1` --- ### 📝 Commits (1) - [`25f1e3d`](https://github.com/hibiken/asynq/commit/25f1e3d9a02aaa81aef87c7c1a17048c3460bbd3) build(deps): bump github.com/prometheus/client_golang in /x ### 📊 Changes **2 files changed** (+22 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `x/go.mod` (+4 -4) 📝 `x/go.sum` (+18 -10) </details> ### 📄 Description Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.5 to 1.21.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prometheus/client_golang/releases">github.com/prometheus/client_golang's releases</a>.</em></p> <blockquote> <h2>v1.21.1 / 2025-03-04</h2> <p>This release addresses a performance regression introduced in <a href="https://redirect.github.com/prometheus/client_golang/issues/1661">#1661</a> -- thanks to all who <a href="https://redirect.github.com/prometheus/client_golang/issues/1748">reported this quickly</a>: <a href="https://github.com/chlunde"><code>@chlunde</code></a>, <a href="https://github.com/dethi"><code>@dethi</code></a>, <a href="https://github.com/aaronbee"><code>@aaronbee</code></a> <a href="https://github.com/tsuna"><code>@tsuna</code></a> <a href="https://github.com/kakkoyun"><code>@kakkoyun</code></a> 💪🏽. This patch release also fixes the iOS build.</p> <p>We will be hardening the release process even further (<a href="https://redirect.github.com/prometheus/client_golang/issues/1759">#1759</a>, <a href="https://redirect.github.com/prometheus/client_golang/issues/1761">#1761</a>) to prevent this in future, sorry for the inconvenience!</p> <p>The high concurrency optimization is planned to be eventually reintroduced, however in a much safer manner, potentially in a separate API.</p> <ul> <li>[BUGFIX] prometheus: Revert of <code>Inc</code>, <code>Add</code> and <code>Observe</code> cumulative metric CAS optimizations (<a href="https://redirect.github.com/prometheus/client_golang/issues/1661">#1661</a>), causing regressions on low concurrency cases <a href="https://redirect.github.com/prometheus/client_golang/issues/1757">#1757</a></li> <li>[BUGFIX] prometheus: Fix GOOS=ios build, broken due to process_collector_* wrong build tags. <a href="https://redirect.github.com/prometheus/client_golang/issues/1758">#1758</a></li> </ul>  <ul> <li>Revert "exponential backoff for CAS operations on floats" and cut 1.21.1 by <a href="https://github.com/bwplotka"><code>@bwplotka</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1757">prometheus/client_golang#1757</a></li> <li>Fix ios build for 1.21.1 by <a href="https://github.com/bwplotka"><code>@bwplotka</code></a> in <a href="https://redirect.github.com/prometheus/client_golang/pull/1758">prometheus/client_golang#1758</a></li> </ul>  <p><strong>Full Changelog</strong>: <a href="https://github.com/prometheus/client_golang/compare/v1.21.0...v1.21.1">https://github.com/prometheus/client_golang/compare/v1.21.0...v1.21.1</a></p> <h2>v1.21.0 / 2025-02-19</h2> <p>:warning: This release contains potential breaking change if you upgrade <code>github.com/prometheus/common</code> to 0.62+ together with client_golang (and depend on the strict, legacy validation for the label names). New common version <a href="https://redirect.github.com/prometheus/common/pull/724">changes <code>model.NameValidationScheme</code> global variable</a>, which relaxes the validation of label names and metric name, allowing all UTF-8 characters. Typically, this should not break any user, unless your test or usage expects strict certain names to panic/fail on client_golang metric registration, gathering or scrape. In case of problems change <code>model.NameValidationScheme</code> to old <code>model.LegacyValidation</code> value in your project <code>init</code> function. :warning:</p> <ul> <li>[BUGFIX] gocollector: Fix help message for runtime/metric metrics. <a href="https://redirect.github.com/prometheus/client_golang/issues/1583">#1583</a></li> <li>[BUGFIX] prometheus: Fix <code>Desc.String()</code> method for no labels case. <a href="https://redirect.github.com/prometheus/client_golang/issues/1687">#1687</a></li> <li>[PERF] prometheus: Optimize popular <code>prometheus.BuildFQName</code> function; now up to 30% faster. <a href="https://redirect.github.com/prometheus/client_golang/issues/1665">#1665</a></li> <li>[PERF] prometheus: Optimize <code>Inc</code>, <code>Add</code> and <code>Observe</code> cumulative metrics; now up to 50% faster under high concurrent contention. <a href="https://redirect.github.com/prometheus/client_golang/issues/1661">#1661</a></li> <li>[CHANGE] Upgrade prometheus/common to 0.62.0 which changes <code>model.NameValidationScheme</code> global variable. <a href="https://redirect.github.com/prometheus/client_golang/issues/1712">#1712</a></li> <li>[CHANGE] Add support for Go 1.23. <a href="https://redirect.github.com/prometheus/client_golang/issues/1602">#1602</a></li> <li>[FEATURE] process_collector: Add support for Darwin systems. <a href="https://redirect.github.com/prometheus/client_golang/issues/1600">#1600</a> <a href="https://redirect.github.com/prometheus/client_golang/issues/1616">#1616</a> <a href="https://redirect.github.com/prometheus/client_golang/issues/1625">#1625</a> <a href="https://redirect.github.com/prometheus/client_golang/issues/1675">#1675</a> <a href="https://redirect.github.com/prometheus/client_golang/issues/1715">#1715</a></li> <li>[FEATURE] api: Add ability to invoke <code>CloseIdleConnections</code> on api.Client using <code>api.Client.(CloseIdler).CloseIdleConnections()</code> casting. <a href="https://redirect.github.com/prometheus/client_golang/issues/1513">#1513</a></li> <li>[FEATURE] promhttp: Add <code>promhttp.HandlerOpts.EnableOpenMetricsTextCreatedSamples</code> option to create OpenMetrics _created lines. Not recommended unless you want to use opt-in Created Timestamp feature. Community works on OpenMetrics 2.0 format that should make those lines obsolete (they increase cardinality significantly). <a href="https://redirect.github.com/prometheus/client_golang/issues/1408">#1408</a></li> <li>[FEATURE] prometheus: Add <code>NewConstNativeHistogram</code> function. <a href="https://redirect.github.com/prometheus/client_golang/issues/1654">#1654</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md">github.com/prometheus/client_golang's changelog</a>.</em></p> <blockquote> <h2>1.21.1 / 2025-03-04</h2> <ul> <li>[BUGFIX] prometheus: Revert of <code>Inc</code>, <code>Add</code> and <code>Observe</code> cumulative metric CAS optimizations (<a href="https://redirect.github.com/prometheus/client_golang/issues/1661">#1661</a>), causing regressions on low contention cases.</li> <li>[BUGFIX] prometheus: Fix GOOS=ios build, broken due to process_collector_* wrong build tags.</li> </ul> <h2>1.21.0 / 2025-02-17</h2> <p>:warning: This release contains potential breaking change if you upgrade <code>github.com/prometheus/common</code> to 0.62+ together with client_golang. :warning:</p> <p>New common version <a href="https://redirect.github.com/prometheus/common/pull/724">changes <code>model.NameValidationScheme</code> global variable</a>, which relaxes the validation of label names and metric name, allowing all UTF-8 characters. Typically, this should not break any user, unless your test or usage expects strict certain names to panic/fail on client_golang metric registration, gathering or scrape. In case of problems change <code>model.NameValidationScheme</code> to old <code>model.LegacyValidation</code> value in your project <code>init</code> function.</p> <ul> <li>[BUGFIX] gocollector: Fix help message for runtime/metric metrics. <a href="https://redirect.github.com/prometheus/client_golang/issues/1583">#1583</a></li> <li>[BUGFIX] prometheus: Fix <code>Desc.String()</code> method for no labels case. <a href="https://redirect.github.com/prometheus/client_golang/issues/1687">#1687</a></li> <li>[ENHANCEMENT] prometheus: Optimize popular <code>prometheus.BuildFQName</code> function; now up to 30% faster. <a href="https://redirect.github.com/prometheus/client_golang/issues/1665">#1665</a></li> <li>[ENHANCEMENT] prometheus: Optimize <code>Inc</code>, <code>Add</code> and <code>Observe</code> cumulative metrics; now up to 50% faster under high concurrent contention. <a href="https://redirect.github.com/prometheus/client_golang/issues/1661">#1661</a></li> <li>[CHANGE] Upgrade prometheus/common to 0.62.0 which changes <code>model.NameValidationScheme</code> global variable. <a href="https://redirect.github.com/prometheus/client_golang/issues/1712">#1712</a></li> <li>[CHANGE] Add support for Go 1.23. <a href="https://redirect.github.com/prometheus/client_golang/issues/1602">#1602</a></li> <li>[FEATURE] process_collector: Add support for Darwin systems. <a href="https://redirect.github.com/prometheus/client_golang/issues/1600">#1600</a> <a href="https://redirect.github.com/prometheus/client_golang/issues/1616">#1616</a> <a href="https://redirect.github.com/prometheus/client_golang/issues/1625">#1625</a> <a href="https://redirect.github.com/prometheus/client_golang/issues/1675">#1675</a> <a href="https://redirect.github.com/prometheus/client_golang/issues/1715">#1715</a></li> <li>[FEATURE] api: Add ability to invoke <code>CloseIdleConnections</code> on api.Client using <code>api.Client.(CloseIdler).CloseIdleConnections()</code> casting. <a href="https://redirect.github.com/prometheus/client_golang/issues/1513">#1513</a></li> <li>[FEATURE] promhttp: Add <code>promhttp.HandlerOpts.EnableOpenMetricsTextCreatedSamples</code> option to create OpenMetrics _created lines. Not recommended unless you want to use opt-in Created Timestamp feature. Community works on OpenMetrics 2.0 format that should make those lines obsolete (they increase cardinality significantly). <a href="https://redirect.github.com/prometheus/client_golang/issues/1408">#1408</a></li> <li>[FEATURE] prometheus: Add <code>NewConstNativeHistogram</code> function. <a href="https://redirect.github.com/prometheus/client_golang/issues/1654">#1654</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prometheus/client_golang/commit/8a42da3e4bfdc7ea408fcd886064dffc4daffb22"><code>8a42da3</code></a> Fix ios build. (<a href="https://redirect.github.com/prometheus/client_golang/issues/1758">#1758</a>)</li> <li><a href="https://github.com/prometheus/client_golang/commit/40c62f7a974e27ba11164f7138d60fd7a3b0c326"><code>40c62f7</code></a> Merge pull request <a href="https://redirect.github.com/prometheus/client_golang/issues/1757">#1757</a> from prometheus/revert-121cas</li> <li><a href="https://github.com/prometheus/client_golang/commit/689f5900164029a73c9a2be6068e1db615107c1f"><code>689f590</code></a> Cut 1.21.1</li> <li><a href="https://github.com/prometheus/client_golang/commit/9e567a7b4fe821af4fad882552ec06713fb8d291"><code>9e567a7</code></a> Revert "Add: exponential backoff for CAS operations on floats (<a href="https://redirect.github.com/prometheus/client_golang/issues/1661">#1661</a>)"</li> <li><a href="https://github.com/prometheus/client_golang/commit/eaf03ef9509cf7e0e56a7d0eda1f11a05506f045"><code>eaf03ef</code></a> Cut 1.21.0 (<a href="https://redirect.github.com/prometheus/client_golang/issues/1737">#1737</a>)</li> <li><a href="https://github.com/prometheus/client_golang/commit/f1f89dc6c527ddf1e80b49c4f56b2c52b164105c"><code>f1f89dc</code></a> Cut 1.21.0-rc.0 (<a href="https://redirect.github.com/prometheus/client_golang/issues/1718">#1718</a>)</li> <li><a href="https://github.com/prometheus/client_golang/commit/c923f7c8e40301ccf857e28f655a241695c470d7"><code>c923f7c</code></a> Revert "ci: daggerize test and lint pipelines (<a href="https://redirect.github.com/prometheus/client_golang/issues/1534">#1534</a>)" (<a href="https://redirect.github.com/prometheus/client_golang/issues/1717">#1717</a>)</li> <li><a href="https://github.com/prometheus/client_golang/commit/1bcda802c13d6334110e088bbef96d32c1c05db7"><code>1bcda80</code></a> process collector: Fixed pedantic registry failures on darwin with cgo. (<a href="https://redirect.github.com/prometheus/client_golang/issues/1715">#1715</a>)</li> <li><a href="https://github.com/prometheus/client_golang/commit/038b37aea518190a66e2d4df5d231e549eed7759"><code>038b37a</code></a> tutorials/whatsup: Updated deps (<a href="https://redirect.github.com/prometheus/client_golang/issues/1716">#1716</a>)</li> <li><a href="https://github.com/prometheus/client_golang/commit/56a24311d5ef75b4c198516ed1c4555318ec729a"><code>56a2431</code></a> docs: Add RELEASE.md for the release process (<a href="https://redirect.github.com/prometheus/client_golang/issues/1690">#1690</a>)</li> <li>Additional commits viewable in <a href="https://github.com/prometheus/client_golang/compare/v1.20.5...v1.21.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/prometheus/client_golang&package-manager=go_modules&previous-version=1.20.5&new-version=1.21.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-03-15 21:15:32 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#3015

No description provided.

Rows
Columns