mirror of
https://github.com/hibiken/asynq.git
synced 2026-04-26 07:25:56 +03:00
[PR #976] feat: allow custom Redis-like broker #2979
Labels
No labels
CLI
bug
designing
documentation
duplicate
enhancement
good first issue
good first issue
help wanted
idea
invalid
investigate
needs-more-info
performance
pr-welcome
pull-request
question
wontfix
work in progress
work in progress
work-around-available
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asynq#2979
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hibiken/asynq/pull/976
Author: @asdfhuang
Created: 12/3/2024
Status: 🔄 Open
Base:
master← Head:feat/custom_broker📝 Commits (2)
7986156feat: allow custom broker6dad2ebfeat: exports broker releated types📊 Changes
8 files changed (+99 additions, -32 deletions)
View changed files
➕
broker/broker.go(+25 -0)📝
client.go(+8 -1)📝
internal/base/base.go(+7 -2)📝
internal/rdb/rdb.go(+28 -3)📝
internal/rdb/rdb_test.go(+5 -5)📝
internal/testbroker/testbroker.go(+2 -3)📝
server.go(+17 -10)📝
subscriber.go(+7 -8)📄 Description
This PR decouples
Brokerinterface from redis and allows creatingServerandClientdirectly from a broker instance. Which makes it possible for custom brokers.For exmaple: Redis from our infrastructure doesn't support pubsub. But I can inherit RDB and implement the pub/sub in another way to make asynq work without a huge amount of work.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.